[coreboot-gerrit] New patch to review for coreboot: mainboard: Get CHROMEOS/MAINBOARD_HAS_CHROMEOS right (again)

[Alexandru Gagniuc (mr.nuke.me@gmail.com)]

Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11290

-gerrit

commit 41dbfa55f32bf1210b39ae19cf6c835e77e4cef4
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Thu Aug 20 12:51:48 2015 -0400

    mainboard: Get CHROMEOS/MAINBOARD_HAS_CHROMEOS right (again)
    
    CHROMEOS is a user-visible bool. It must not be 'select'ed in Kconfig.
    That's why we have MAINBOARD_HAS_CHROMEOS. This is the fifth time I
    find this being used wrong.
    Why is this confusing/so hard to get right?
    
    Change-Id: Icb4629355c63508f5a044b46842524b3d203c2da
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/mainboard/google/cyan/Kconfig     | 1 -
 src/mainboard/google/glados/Kconfig   | 1 -
 src/mainboard/intel/kunimitsu/Kconfig | 1 -
 src/mainboard/intel/sklrvp/Kconfig    | 1 -
 src/mainboard/intel/strago/Kconfig    | 1 -
 5 files changed, 5 deletions(-)

diff --git a/src/mainboard/google/cyan/Kconfig b/src/mainboard/google/cyan/Kconfig
index 91f7587..094c629 100644
--- a/src/mainboard/google/cyan/Kconfig
+++ b/src/mainboard/google/cyan/Kconfig
@@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS
 	select VGA_ROM_RUN if !PAYLOAD_SEABIOS
 	select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS
 	select BOARD_ROMSIZE_KB_8192
-	select CHROMEOS
 	select CHROMEOS_VBNV_CMOS
 	select EC_GOOGLE_CHROMEEC
 	select EC_GOOGLE_CHROMEEC_MEC
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index c7df2a3..d91aca5 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -4,7 +4,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384
 	select CACHE_ROM
-	select CHROMEOS
 	select CHROMEOS_RAMOOPS_DYNAMIC
 	select CHROMEOS_VBNV_CMOS
 	select EC_GOOGLE_CHROMEEC
diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig
index 78d4081..cb7ce29 100644
--- a/src/mainboard/intel/kunimitsu/Kconfig
+++ b/src/mainboard/intel/kunimitsu/Kconfig
@@ -4,7 +4,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384
 	select CACHE_ROM
-	select CHROMEOS
 	select CHROMEOS_RAMOOPS_DYNAMIC
 	select CHROMEOS_VBNV_CMOS
 	select EC_GOOGLE_CHROMEEC
diff --git a/src/mainboard/intel/sklrvp/Kconfig b/src/mainboard/intel/sklrvp/Kconfig
index 601efb0..1741469 100644
--- a/src/mainboard/intel/sklrvp/Kconfig
+++ b/src/mainboard/intel/sklrvp/Kconfig
@@ -4,7 +4,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	def_bool y
 	select BOARD_ROMSIZE_KB_16384
 	select CACHE_ROM
-	select CHROMEOS
 	select CHROMEOS_RAMOOPS_DYNAMIC
 	select CHROMEOS_VBNV_CMOS
 	select HAVE_ACPI_RESUME
diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig
index c19761a..599a84a 100755
--- a/src/mainboard/intel/strago/Kconfig
+++ b/src/mainboard/intel/strago/Kconfig
@@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS
 	select VGA_ROM_RUN if !PAYLOAD_SEABIOS
 	select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS
 	select BOARD_ROMSIZE_KB_8192
-	select CHROMEOS
 	select CHROMEOS_VBNV_CMOS
 	select EC_GOOGLE_CHROMEEC
 	select EC_GOOGLE_CHROMEEC_MEC