[coreboot-gerrit] New patch to review for coreboot: cbfstool/Makefile.inc: Specify output filename in fmd_parser rule
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Thu Aug 20 20:53:41 CEST 2015
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11292
-gerrit
commit 518920d6fa93ae0006ed039b7152550eb63af631
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date: Thu Aug 20 14:44:48 2015 -0400
cbfstool/Makefile.inc: Specify output filename in fmd_parser rule
The fmd_parser.c rule called $(YACC), assuming that the output
filename is "y.tab.c". This isn't always the case as illustrated by
$ YACC=bison make
When the output file is specified, cbfstool compiles with the above,
and as a bonus, we kill two useless "cp" invocations.
Change-Id: I4e892773f380d99705a2b752bd88e964cf8553eb
Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
util/cbfstool/Makefile | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile
index 65d5710..7e8142b 100644
--- a/util/cbfstool/Makefile
+++ b/util/cbfstool/Makefile
@@ -61,9 +61,7 @@ fmd_scanner.c: fmd_scanner.l
fmd_parser.h: fmd_parser.c
fmd_parser.c: fmd_parser.y
- $(YACC) $(YFLAGS) -d $<
- mv -f y.tab.c $*.c
- mv -f y.tab.h $*.h
+ $(YACC) $(YFLAGS) -o "$*.c" -d $<
.PHONY: clean
clean:
More information about the coreboot-gerrit
mailing list