[coreboot-gerrit] New patch to review for coreboot: AMD Kconfig: Remove QRANK_DIMM_SUPPORT from unsupported platforms
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Fri Aug 21 22:16:51 CEST 2015
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11300
-gerrit
commit eed9fa1fb7f1ecdb08a95da9ed43a99519cc6a7d
Author: Martin Roth <martinroth at google.com>
Date: Fri Aug 21 14:15:42 2015 -0600
AMD Kconfig: Remove QRANK_DIMM_SUPPORT from unsupported platforms
The AMD K8 northbridge uses the Kconfig symbol QRANK_DIMM_SUPPORT,
but the symbol was used on a number of Family 10 boards as well.
AMD Family 10 doesn't use this Kconfig symbol for anything.
I verified that the symbol wasn't used actually getting used in any
of these platforms.
Fixes Kconfig warnings for these 19 mainboards:
warning: (BOARD_SPECIFIC_OPTIONS...) selects QRANK_DIMM_SUPPORT which
has unmet direct dependencies (NORTHBRIDGE_AMD_AMDK8)
Change-Id: I454992a4975566fd6439a21f5a800d0cfa1b4d3b
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/mainboard/advansus/a785e-i/Kconfig | 1 -
src/mainboard/amd/bimini_fam10/Kconfig | 3 ---
src/mainboard/amd/mahogany_fam10/Kconfig | 1 -
src/mainboard/amd/serengeti_cheetah_fam10/Kconfig | 1 -
src/mainboard/amd/tilapia_fam10/Kconfig | 1 -
src/mainboard/asus/m4a78-em/Kconfig | 1 -
src/mainboard/asus/m4a785-m/Kconfig | 1 -
src/mainboard/asus/m4a785t-m/Kconfig | 1 -
src/mainboard/asus/m5a88-v/Kconfig | 1 -
src/mainboard/avalue/eax-785e/Kconfig | 1 -
src/mainboard/gigabyte/ma785gm/Kconfig | 1 -
src/mainboard/gigabyte/ma785gmt/Kconfig | 1 -
src/mainboard/gigabyte/ma78gm/Kconfig | 1 -
src/mainboard/iei/kino-780am2-fam10/Kconfig | 1 -
src/mainboard/jetway/pa78vm5/Kconfig | 1 -
src/mainboard/msi/ms9652_fam10/Kconfig | 1 -
src/mainboard/supermicro/h8dmr_fam10/Kconfig | 1 -
src/mainboard/supermicro/h8qme_fam10/Kconfig | 1 -
src/mainboard/tyan/s2912_fam10/Kconfig | 1 -
19 files changed, 21 deletions(-)
diff --git a/src/mainboard/advansus/a785e-i/Kconfig b/src/mainboard/advansus/a785e-i/Kconfig
index b6213d5..3094759 100644
--- a/src/mainboard/advansus/a785e-i/Kconfig
+++ b/src/mainboard/advansus/a785e-i/Kconfig
@@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select CPU_AMD_SOCKET_ASB2
select DIMM_DDR3
select DIMM_REGISTERED
- select QRANK_DIMM_SUPPORT
select NORTHBRIDGE_AMD_AMDFAM10
select SOUTHBRIDGE_AMD_RS780
select SOUTHBRIDGE_AMD_CIMX_SB800
diff --git a/src/mainboard/amd/bimini_fam10/Kconfig b/src/mainboard/amd/bimini_fam10/Kconfig
index 261c60a..f30c972 100644
--- a/src/mainboard/amd/bimini_fam10/Kconfig
+++ b/src/mainboard/amd/bimini_fam10/Kconfig
@@ -5,9 +5,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select CPU_AMD_SOCKET_ASB2
select DIMM_DDR3
select DIMM_REGISTERED
- # TODO: Enable QRANK_DIMM_SUPPORT? Was commented in the Kconfig file,
- # but enabled in the romstage.c file.
- select QRANK_DIMM_SUPPORT
select NORTHBRIDGE_AMD_AMDFAM10
select SOUTHBRIDGE_AMD_RS780
select SOUTHBRIDGE_AMD_SB800
diff --git a/src/mainboard/amd/mahogany_fam10/Kconfig b/src/mainboard/amd/mahogany_fam10/Kconfig
index 393882c..5ca1ef5 100644
--- a/src/mainboard/amd/mahogany_fam10/Kconfig
+++ b/src/mainboard/amd/mahogany_fam10/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig b/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
index 3e6e025..ef34cd6 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select LIFT_BSP_APIC_ID
- select QRANK_DIMM_SUPPORT
select DRIVERS_I2C_I2CMUX2
config MAINBOARD_DIR
diff --git a/src/mainboard/amd/tilapia_fam10/Kconfig b/src/mainboard/amd/tilapia_fam10/Kconfig
index 254cf66..2f81b31 100644
--- a/src/mainboard/amd/tilapia_fam10/Kconfig
+++ b/src/mainboard/amd/tilapia_fam10/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/asus/m4a78-em/Kconfig b/src/mainboard/asus/m4a78-em/Kconfig
index 0382daf..4300afc 100644
--- a/src/mainboard/asus/m4a78-em/Kconfig
+++ b/src/mainboard/asus/m4a78-em/Kconfig
@@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/asus/m4a785-m/Kconfig b/src/mainboard/asus/m4a785-m/Kconfig
index a945d2a..ed8d41c 100644
--- a/src/mainboard/asus/m4a785-m/Kconfig
+++ b/src/mainboard/asus/m4a785-m/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/asus/m4a785t-m/Kconfig b/src/mainboard/asus/m4a785t-m/Kconfig
index a347f02..c7dcb2e 100644
--- a/src/mainboard/asus/m4a785t-m/Kconfig
+++ b/src/mainboard/asus/m4a785t-m/Kconfig
@@ -20,7 +20,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/asus/m5a88-v/Kconfig b/src/mainboard/asus/m5a88-v/Kconfig
index a5f19f5..8f2ede1 100644
--- a/src/mainboard/asus/m5a88-v/Kconfig
+++ b/src/mainboard/asus/m5a88-v/Kconfig
@@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select CPU_AMD_SOCKET_AM3
select DIMM_DDR3
select DIMM_REGISTERED
- select QRANK_DIMM_SUPPORT
select NORTHBRIDGE_AMD_AMDFAM10
select SOUTHBRIDGE_AMD_RS780
select SOUTHBRIDGE_AMD_CIMX_SB800
diff --git a/src/mainboard/avalue/eax-785e/Kconfig b/src/mainboard/avalue/eax-785e/Kconfig
index 9d7c2e0..09a1d2d 100644
--- a/src/mainboard/avalue/eax-785e/Kconfig
+++ b/src/mainboard/avalue/eax-785e/Kconfig
@@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select CPU_AMD_SOCKET_AM3
select DIMM_DDR3
select DIMM_REGISTERED
- select QRANK_DIMM_SUPPORT
select NORTHBRIDGE_AMD_AMDFAM10
select SOUTHBRIDGE_AMD_RS780
select SOUTHBRIDGE_AMD_CIMX_SB800
diff --git a/src/mainboard/gigabyte/ma785gm/Kconfig b/src/mainboard/gigabyte/ma785gm/Kconfig
index bf441e9..90aac18 100644
--- a/src/mainboard/gigabyte/ma785gm/Kconfig
+++ b/src/mainboard/gigabyte/ma785gm/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/gigabyte/ma785gmt/Kconfig b/src/mainboard/gigabyte/ma785gmt/Kconfig
index 827c8da..87a5f88 100644
--- a/src/mainboard/gigabyte/ma785gmt/Kconfig
+++ b/src/mainboard/gigabyte/ma785gmt/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/gigabyte/ma78gm/Kconfig b/src/mainboard/gigabyte/ma78gm/Kconfig
index 3d85708..b2fe182 100644
--- a/src/mainboard/gigabyte/ma78gm/Kconfig
+++ b/src/mainboard/gigabyte/ma78gm/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/iei/kino-780am2-fam10/Kconfig b/src/mainboard/iei/kino-780am2-fam10/Kconfig
index 4b3bce6..6356949 100644
--- a/src/mainboard/iei/kino-780am2-fam10/Kconfig
+++ b/src/mainboard/iei/kino-780am2-fam10/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/jetway/pa78vm5/Kconfig b/src/mainboard/jetway/pa78vm5/Kconfig
index 30478d2..c68ba24 100644
--- a/src/mainboard/jetway/pa78vm5/Kconfig
+++ b/src/mainboard/jetway/pa78vm5/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select GFXUMA
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/msi/ms9652_fam10/Kconfig b/src/mainboard/msi/ms9652_fam10/Kconfig
index c64fdda..3440cad 100644
--- a/src/mainboard/msi/ms9652_fam10/Kconfig
+++ b/src/mainboard/msi/ms9652_fam10/Kconfig
@@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_512
select ENABLE_APIC_EXT_ID
select SB_HT_CHAIN_UNITID_OFFSET_ONLY
- select QRANK_DIMM_SUPPORT
select LIFT_BSP_APIC_ID
select IOAPIC
select SMP
diff --git a/src/mainboard/supermicro/h8dmr_fam10/Kconfig b/src/mainboard/supermicro/h8dmr_fam10/Kconfig
index 0d20204..0a352f7 100644
--- a/src/mainboard/supermicro/h8dmr_fam10/Kconfig
+++ b/src/mainboard/supermicro/h8dmr_fam10/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/supermicro/h8qme_fam10/Kconfig b/src/mainboard/supermicro/h8qme_fam10/Kconfig
index 27a74bb..687b1e5 100644
--- a/src/mainboard/supermicro/h8qme_fam10/Kconfig
+++ b/src/mainboard/supermicro/h8qme_fam10/Kconfig
@@ -16,7 +16,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
diff --git a/src/mainboard/tyan/s2912_fam10/Kconfig b/src/mainboard/tyan/s2912_fam10/Kconfig
index 5ae5a22..8a517e5 100644
--- a/src/mainboard/tyan/s2912_fam10/Kconfig
+++ b/src/mainboard/tyan/s2912_fam10/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID
select MMCONF_SUPPORT_DEFAULT
- select QRANK_DIMM_SUPPORT
config MAINBOARD_DIR
string
More information about the coreboot-gerrit
mailing list