[coreboot-gerrit] Patch set updated for coreboot: x86: Get rid of empty loadable segment warning

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11302

-gerrit

commit 9e417a6e6c96ec63d3085e3d2dfd147c0a169a4e
Author: Martin Roth <martinroth at google.com>
Date:   Sat Aug 22 10:37:39 2015 -0600

    x86: Get rid of empty loadable segment warning
    
    When the check for global symbols in romstage happens, if everything is
    good, a warning appears, telling us that the segment is empty. While the
    empty segment is good, the warning is distracting:
    
    "BFD: build/cbfs/fallback/romstage_null.debug: warning: Empty loadable
    segment detected, is this intentional ?"
    
    This change hides that particular warning, but shouldn't hide any other
    output from objcopy.
    
    Change-Id: If22489280712d02a61c3ee5e0cb2a53db87d6082
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/arch/x86/Makefile.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index d0b276d..3a8d8d5 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -207,7 +207,8 @@ endif
 $(objcbfs)/romstage_null.debug: $$(romstage-objs) $(objgenerated)/romstage_null.ld $$(romstage-libs)
 	@printf "    LINK       $(subst $(obj)/,,$(@))\n"
 	$(LD_romstage) --gc-sections -nostdlib -nostartfiles -static -o $@ -L$(obj) $(COMPILER_RT_FLAGS_romstage) --whole-archive --start-group $(filter-out %.ld,$(romstage-objs)) $(romstage-libs) --no-whole-archive $(COMPILER_RT_romstage) --end-group -T $(objgenerated)/romstage_null.ld --oformat $(romstage-oformat)
-	$(OBJCOPY_romstage) --only-section .illegal_globals $(@) $(objcbfs)/romstage_null.offenders && \
+	LANG=C LC_ALL= $(OBJCOPY_romstage) --only-section .illegal_globals $(@) $(objcbfs)/romstage_null.offenders 2>&1 | \
+	grep -v "Empty loadable segment detected" && \
 	$(NM_romstage) $(objcbfs)/romstage_null.offenders | grep -q ""; if [ $$? -eq 0 ]; then \
 		echo "Forbidden global variables in romstage:"; \
 		$(NM_romstage) $(objcbfs)/romstage_null.offenders; false; \