[coreboot-gerrit] Patch set updated for coreboot: xcompile: Force localization of objdump to C

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Mon Aug 24 20:45:55 CEST 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11304

-gerrit

commit 94dac798dd57b7685b4b8ee2ecb3801e8229b116
Author: Martin Roth <martinroth at google.com>
Date:   Mon Aug 24 11:26:20 2015 -0600

    xcompile: Force localization of objdump to C
    
    In testing other localization changes, I found that I couldn't build
    anymore because xcompile wasn't picking up my toolchain.  I traced it
    to the regex comparison of '.*format \(.[a-z0-9-]*\)' to the string
    'formato del fichero elf32-i386'.  Forcing the localization of
    objdump to C before doing the comparison fixes the issue.
    
    Change-Id: I6bed5a9824807dd5bc5a38b711ab47e2af4b0c29
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/xcompile/xcompile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 4560771..e712ac3 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -103,7 +103,7 @@ testas() {
 		2>/dev/null || return 1
 
 	# Check output content type.
-	local obj_type="$(${gccprefix}objdump -p $obj_file)"
+	local obj_type="$(LANG=C LC_ALL= ${gccprefix}objdump -p $obj_file)"
 	local obj_arch="$(expr "$obj_type" : '.*format \(.[a-z0-9-]*\)')"
 	[ "$obj_arch" = "$full_arch" ] || return 1
 



More information about the coreboot-gerrit mailing list