[coreboot-gerrit] New patch to review for coreboot: cbfstool: passing a header is now mandatory for converters

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Aug 25 20:18:45 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11330

-gerrit

commit ef158379dcbd53f17d6b54375bc4518be62b7894
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Tue Aug 25 20:17:14 2015 +0200

    cbfstool: passing a header is now mandatory for converters
    
    Change-Id: Iea5377af735b06bcaefb999547a8896b1c70763a
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 util/cbfstool/cbfstool.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index ae75b91..feb7291 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -245,8 +245,7 @@ static int cbfstool_convert_mkstage(struct buffer *buffer, uint32_t *offset,
 	buffer_delete(buffer);
 	// direct assign, no dupe.
 	memcpy(buffer, &output, sizeof(*buffer));
-	if (header)
-		header->len = htonl(output.size);
+	header->len = htonl(output.size);
 	return 0;
 }
 
@@ -277,8 +276,7 @@ static int cbfstool_convert_mkpayload(struct buffer *buffer,
 	buffer_delete(buffer);
 	// direct assign, no dupe.
 	memcpy(buffer, &output, sizeof(*buffer));
-	if (header)
-		header->len = htonl(output.size);
+	header->len = htonl(output.size);
 	return 0;
 }
 
@@ -295,8 +293,7 @@ static int cbfstool_convert_mkflatpayload(struct buffer *buffer,
 	buffer_delete(buffer);
 	// direct assign, no dupe.
 	memcpy(buffer, &output, sizeof(*buffer));
-	if (header)
-		header->len = htonl(output.size);
+	header->len = htonl(output.size);
 	return 0;
 }
 



More information about the coreboot-gerrit mailing list