[coreboot-gerrit] New patch to review for coreboot: Remove dependency for HAS_PRECBMEM_TIMESTAMP_REGION

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Aug 26 01:11:04 CEST 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11338

-gerrit

commit b4be267f23121340ffed769b5ac04352e0cdeb2e
Author: Martin Roth <martinroth at google.com>
Date:   Mon Aug 24 16:42:31 2015 -0600

    Remove dependency for HAS_PRECBMEM_TIMESTAMP_REGION
    
    HAS_PRECBMEM_TIMESTAMP_REGION was dependent on COLLECT_TIMESTAMPS,
    but should be allowed to be selected independently.  My thought is that
    the code may only be used when collecting timestamps, the HAS prefix
    signifies that this is a platform configuration option.
    
    This fix could also be done by adding 'if COLLECT_TIMESTAMPS' everywhere
    that 'select HAS_PRECBMEM_TIMESTAMP_REGION' is used
    
    Change-Id: Iaf4895475c38a855a048dc9b82d4c97e5e3f4e5c
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/Kconfig b/src/Kconfig
index 9c01687..5227bcd 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -203,7 +203,6 @@ config COLLECT_TIMESTAMPS
 config HAS_PRECBMEM_TIMESTAMP_REGION
 	bool "Timestamp region exists for pre-cbmem timestamps"
 	default y if ARCH_ROMSTAGE_X86_32 && CACHE_AS_RAM
-	depends on COLLECT_TIMESTAMPS
 	help
 	  A separate region is maintained to allow storing of timestamps before
 	  cbmem comes up. This is useful for storing timestamps across different



More information about the coreboot-gerrit mailing list