[coreboot-gerrit] New patch to review for coreboot: packardbell/ms2290/mainboard.c: Do not guard int15 includes

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Thu Aug 27 08:09:58 CEST 2015


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11379

-gerrit

commit 3fb4c8c36123ee89000c96353899d98cba1200e1
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Aug 26 23:04:34 2015 -0700

    packardbell/ms2290/mainboard.c: Do not guard int15 includes
    
    Do not guard the inclusion of "drivers/intel/gma/int15.h"
    and "arch/interrupt.h" with configs that control option rom execution.
    These headers already have the proper guards. The
    install_intel_vga_int15_handler() is unconditionally called, even when
    the header that declares it is guarded out.
    
    Change-Id: Ia273437486f5802aa2b53212f2a1b5704c9485fa
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/mainboard/packardbell/ms2290/mainboard.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mainboard/packardbell/ms2290/mainboard.c b/src/mainboard/packardbell/ms2290/mainboard.c
index 5a4882f..bddc8a8 100644
--- a/src/mainboard/packardbell/ms2290/mainboard.c
+++ b/src/mainboard/packardbell/ms2290/mainboard.c
@@ -34,10 +34,8 @@
 
 #include <pc80/mc146818rtc.h>
 #include <arch/x86/include/arch/acpigen.h>
-#if CONFIG_PCI_OPTION_ROM_RUN_YABEL || CONFIG_PCI_OPTION_ROM_RUN_REALMODE
 #include <drivers/intel/gma/int15.h>
 #include <arch/interrupt.h>
-#endif
 #include <pc80/keyboard.h>
 #include <cpu/x86/lapic.h>
 #include <device/pci.h>



More information about the coreboot-gerrit mailing list