[coreboot-gerrit] Patch set updated for coreboot: veyron_rialto: Force 3G modem off

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Aug 27 17:28:33 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11385

-gerrit

commit ee2f8bcd2d301dd074427407686aadb273129d27
Author: David Hendricks <dhendrix at chromium.org>
Date:   Wed Aug 5 14:13:34 2015 -0700

    veyron_rialto: Force 3G modem off
    
    This basically does the same thing for firmware what CL:290631
    did in the kernel. We want to keep the modem off until it needs
    to be used to avoid enumeration/detection issues.
    
    BUG=chrome-os-partner:43271
    BRANCH=none
    TEST=needs testing
    
    Change-Id: I3b63a77c732dc4895b728b30f1dd71210a9c0e90
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: a90ccd7fbffe44abe05e96341cc77067442c85e4
    Original-Change-Id: I3516de1ea9160f7186ad7f5fb3b5d29ac73143b5
    Original-Signed-off-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/290890
    Original-Reviewed-by: Alexandru Stan <amstan at chromium.org>
---
 src/mainboard/google/veyron_rialto/mainboard.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/mainboard/google/veyron_rialto/mainboard.c b/src/mainboard/google/veyron_rialto/mainboard.c
index 52a27bb..4dba666 100644
--- a/src/mainboard/google/veyron_rialto/mainboard.c
+++ b/src/mainboard/google/veyron_rialto/mainboard.c
@@ -72,6 +72,14 @@ static void configure_codec(void)
 	rkclk_configure_i2s(12288000);
 }
 
+static void configure_3g(void)
+{
+	/* Force 3G modem off to avoid confusing the EHCI host and
+	 * causing problems during enumeration/init */
+	gpio_output(GPIO(5, C, 1), 1);	/* 3G_SHUTDOWN */
+	gpio_output(GPIO(4, D, 2), 0);	/* 3G_ON_OFF */
+}
+
 static void mainboard_init(device_t dev)
 {
 	gpio_output(GPIO_RESET, 0);
@@ -79,6 +87,7 @@ static void mainboard_init(device_t dev)
 	configure_usb();
 	configure_emmc();
 	configure_codec();
+	configure_3g();
 	/* No video. */
 
 	elog_init();



More information about the coreboot-gerrit mailing list