[coreboot-gerrit] Patch merged into coreboot/master: veyron_rialto: Turn on all leds

gerrit at coreboot.org gerrit at coreboot.org
Fri Aug 28 08:44:49 CEST 2015


the following patch was just integrated into master:
commit affb88b27140bfcdaf2a8cbd44b9ff90d6dee8d8
Author: Alexandru M Stan <amstan at chromium.org>
Date:   Mon Aug 17 17:32:06 2015 -0700

    veyron_rialto: Turn on all leds
    
    Without this, the leds would be stuck to whatever the pullup/down states the
    pins come with on rk3288.
    
    Ready2_LED, an orange led, is one of the leds in this state.
    This might confuse some users thinking there's an error.
    
    Turn all of them on instead.
    Later on depthcharge will use the same LEDs to indicate dev mode status.
    
    BUG=chrome-os-partner:44274
    BRANCH=master
    TEST=Boot firmware without anything else, note all leds on
    
    Change-Id: I5cf19aabd2a59a61699ef491ae11424cf5a0c874
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: 2e1a332a5653fb76bbf8fe624274ec64d2b443a5
    Original-Change-Id: I4c4e8940dd9cf1ac0301ac00bfc5992ba16e1589
    Original-Signed-off-by: Alexandru M Stan <amstan at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/294065
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-on: http://review.coreboot.org/11398
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/11398 for details.

-gerrit



More information about the coreboot-gerrit mailing list