[coreboot-gerrit] Patch set updated for coreboot: intel/kunimitsu: clean up ec smi and make EC_SMI_L functional
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Sat Aug 29 09:31:05 CEST 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11428
-gerrit
commit a0d0ada1f3f2ab35d043b28103e37c4c1a48b37b
Author: robbie zhang <robbie.zhang at intel.com>
Date: Fri Aug 21 12:56:04 2015 -0700
intel/kunimitsu: clean up ec smi and make EC_SMI_L functional
forward port of "glados: make EC_SMI_L functional",
commit 50ed38feba58f
BUG=None
BRANCH=None
TEST=Built and booted kunimitsu.
CQ-DEPEND=CL:295012
Change-Id: I41daeb8b729f2de117b5d57c460925437460e50a
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
Original-Commit-Id: d9308c0b8eb05c756d88dc0c3d761c9e76d07e08
Original-Change-Id: Ia90c70d21af75d0f0da2af2b4437ccf26659a157
Original-Signed-off-by: robbie zhang <robbie.zhang at intel.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/295045
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Original-Tested-by: Wenkai Du <wenkai.du at intel.com>
---
src/mainboard/intel/kunimitsu/ec.h | 4 ++--
src/mainboard/intel/kunimitsu/smihandler.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/mainboard/intel/kunimitsu/ec.h b/src/mainboard/intel/kunimitsu/ec.h
index 9da9d9f..9c8a9d1 100644
--- a/src/mainboard/intel/kunimitsu/ec.h
+++ b/src/mainboard/intel/kunimitsu/ec.h
@@ -22,11 +22,11 @@
#define MAINBOARD_EC_H
#include <ec/google/chromeec/ec_commands.h>
+#include <soc/gpio.h>
/* GPP_E16 is EC_SCI_L */
#define EC_SCI_GPI 16 /* TODO: Update this */
-/* GPP_E15 is EC_SMI_L */
-#define EC_SMI_GPI 15 /* TODO: Update this */
+#define EC_SMI_GPI GPP_E15
#define MAINBOARD_EC_SCI_EVENTS \
(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED) |\
diff --git a/src/mainboard/intel/kunimitsu/smihandler.c b/src/mainboard/intel/kunimitsu/smihandler.c
index 0529ba1..fe8e70c 100644
--- a/src/mainboard/intel/kunimitsu/smihandler.c
+++ b/src/mainboard/intel/kunimitsu/smihandler.c
@@ -74,10 +74,9 @@ static u8 mainboard_smi_ec(void)
return cmd;
}
-/* gpi_sts is GPIO 47:32 */
-void mainboard_smi_gpi(u32 gpi_sts)
+void mainboard_smi_gpi_handler(const struct gpi_status *sts)
{
- if (gpi_sts & (1 << EC_SMI_GPI)) {
+ if (gpi_status_get(sts, EC_SMI_GPI)) {
/* Process all pending events */
while (mainboard_smi_ec() != 0)
;
More information about the coreboot-gerrit
mailing list