[coreboot-gerrit] Patch set updated for coreboot: google/glados: Remove unnecessary check for mainboard_ec_init()

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Sat Aug 29 09:33:56 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11435

-gerrit

commit 42483871ac3a6d59c5766cac24d43036fc0b83d1
Author: Martin Roth <martinroth at chromium.org>
Date:   Tue Aug 25 11:26:33 2015 -0600

    google/glados: Remove unnecessary check for mainboard_ec_init()
    
    mainboard_ec_init() wasn't getting run due to an invalid
    Kconfig symbol.  This check isn't required as the Kconfig
    option for the EC is forced to be enabled, and the function
    should always be run.
    
    BRANCH=none
    BUG=none
    TEST=Rebuilt glados mainboard.
    
    Change-Id: I2c4a33d80533a19b02b83b3aaa6a3386e927f1c7
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: edd8c7a0666208b35ee81f57ec2626390958dfb7
    Original-Change-Id: I2a92fd28347455c09ecf2119788ca9b6a97a11de
    Original-Signed-off-by: Martin Roth <martinroth at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/295143
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/glados/mainboard.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mainboard/google/glados/mainboard.c b/src/mainboard/google/glados/mainboard.c
index 5e48f17..ac4a2ad 100644
--- a/src/mainboard/google/glados/mainboard.c
+++ b/src/mainboard/google/glados/mainboard.c
@@ -25,8 +25,7 @@
 
 static void mainboard_init(device_t dev)
 {
-	if (IS_ENABLED(CONFIG_GOOGLE_CHROME_EC))
-		mainboard_ec_init();
+	mainboard_ec_init();
 }
 
 /*



More information about the coreboot-gerrit mailing list