[coreboot-gerrit] New patch to review for coreboot: intel/fsp1_1: Add accurate print for full fsp version

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12594

-gerrit

commit f7a7b7da799a6fee40c0fc92b9c58f936ca35100
Author: Dhaval Sharma <dhaval.v.sharma at intel.com>
Date:   Mon Nov 2 17:12:10 2015 +0530

    intel/fsp1_1: Add accurate print for full fsp version
    
    Adding print for full fsp revision which includes:
    0:7   - Build number
    8:15  - Revision
    16:23 - Minor version
    24:31 - Major version
    
    BRANCH=NONE
    BUG=chrome-os-partner:46050
    TEST=Built for kunimitsu and tested fsp revision is printed properly.
    
    Change-Id: If2739e7cccd97e4b39da503a9d61222cde03bc95
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: c49be46f8d2085a620abac74126de5c3b634e649
    Original-Change-Id: I2223cce22fb3d39faa37902d415d5fdbe321add6
    Original-Signed-off-by: Dhaval Sharma <dhaval.v.sharma at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/310173
    Original-Commit-Ready: dhaval v sharma <dhaval.v.sharma at intel.com>
    Original-Tested-by: dhaval v sharma <dhaval.v.sharma at intel.com>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/drivers/intel/fsp1_1/fsp_util.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c
index a4b623d..21239bd 100644
--- a/src/drivers/intel/fsp1_1/fsp_util.c
+++ b/src/drivers/intel/fsp1_1/fsp_util.c
@@ -112,7 +112,9 @@ void print_fsp_info(FSP_INFO_HEADER *fsp_header)
 			fsp_header->ImageId[6], fsp_header->ImageId[7]);
 	printk(BIOS_INFO, "FSP Header Version: %d\n",
 			fsp_header->HeaderRevision);
-	printk(BIOS_INFO, "FSP Revision: %d.%d\n",
+	printk(BIOS_INFO, "FSP Revision: %d.%d.%d.%d\n",
+			(u8)((fsp_header->ImageRevision >> 24) & 0xff),
+			(u8)((fsp_header->ImageRevision >> 16) & 0xff),
 			(u8)((fsp_header->ImageRevision >> 8) & 0xff),
 			(u8)(fsp_header->ImageRevision  & 0xff));
 #if IS_ENABLED(CONFIG_DISPLAY_FSP_ENTRY_POINTS)