[coreboot-gerrit] New patch to review for coreboot: intel/skylake: Remove unused code to add SSDT2

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Dec 1 19:57:38 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12596

-gerrit

commit 53d3e292bc757ec6cd1c7b22d2542de638994d9f
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Sat Nov 21 18:42:10 2015 -0800

    intel/skylake: Remove unused code to add SSDT2
    
    This code is doing nothing and is not needed.
    
    BUG=chrome-os-partner:40635
    BRANCH=none
    TEST=build and boot on glados
    
    Change-Id: I910d443f09a94de1ee0de03cda0577b8847b2de8
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: ac09fdd7673e5fceb8bfaf1076a8a91e54fc31af
    Original-Change-Id: Id989c82853d5a5d5b750def073d34c39816a48d5
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/313823
    Original-Commit-Ready: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/skylake/acpi.c | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index cd8b86f..36b5bb4 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -541,26 +541,8 @@ unsigned long southcluster_write_acpi_tables(device_t device,
 					     unsigned long current,
 					     struct acpi_rsdp *rsdp)
 {
-	acpi_header_t *ssdt2;
-
 	current = acpi_write_hpet(device, current, rsdp);
 	ALIGN_CURRENT;
-
-	ssdt2 = (acpi_header_t *)current;
-	memset(ssdt2, 0, sizeof(acpi_header_t));
-	if (ssdt2->length) {
-		current += ssdt2->length;
-		acpi_add_table(rsdp, ssdt2);
-		printk(BIOS_DEBUG, "ACPI:     * SSDT2 @ %p Length %x\n",ssdt2,
-		       ssdt2->length);
-		ALIGN_CURRENT;
-	} else {
-		ssdt2 = NULL;
-		printk(BIOS_DEBUG, "ACPI:     * SSDT2 not generated.\n");
-	}
-
-	printk(BIOS_DEBUG, "current = %lx\n", current);
-
 	return current;
 }
 



More information about the coreboot-gerrit mailing list