[coreboot-gerrit] New patch to review for coreboot: amdfwtool: Fill all the romsig entries as 0

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Mon Dec 7 11:10:28 CET 2015


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12665

-gerrit

commit d813ea0b167304f62748f2fa97e05ecebe71a834
Author: zbao <fishbaozi at gmail.com>
Date:   Mon Dec 7 05:11:20 2015 -0500

    amdfwtool: Fill all the romsig entries as 0
    
    I didn't go back through the development guide for this.
    But based on test, if the empty entry is filled as 0xFFFFFFFF,
    instead of 0, the USB3 port can not be used.
    
    Change-Id: Icd5f9891e541279dbd551bbceaf091488d22bfef
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 util/amdfwtool/amdfwtool.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index f958aba..7b04921 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -377,6 +377,10 @@ int main(int argc, char **argv)
 	current = AMD_ROMSIG_OFFSET;
 	amd_romsig = rom + AMD_ROMSIG_OFFSET;
 	amd_romsig[0] = 0x55AA55AA; /* romsig */
+	amd_romsig[1] = 0;
+	amd_romsig[2] = 0;
+	amd_romsig[3] = 0;
+	amd_romsig[4] = 0;
 
 	current += 0x20;	    /* size of ROMSIG */
 



More information about the coreboot-gerrit mailing list