[coreboot-gerrit] New patch to review for coreboot: AMD/bettong: Remove the device definitions in ASL

[Zheng Bao (zheng.bao@amd.com)]

Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12667

-gerrit

commit 55095a496cb1dc282a866c082f7f96d900e35389
Author: zbao <fishbaozi at gmail.com>
Date:   Mon Dec 7 07:35:31 2015 -0500

    AMD/bettong: Remove the device definitions in ASL
    
    If we include the device definitions in ASL, there is
    "Error Code 12 This device cannot find enough free resources"
    in device manager. After the definitions are removed,
    we can still see the i2c, uart, gpio entries in device manager.
    
    I assume this definitions are already provided by AGESA
    is SSDT.
    
    Since this fixes the warning message in device manager,
    we can abandon the change below.
    ----------------------
    https://review.coreboot.org/#/c/11747/
    AMD/Bettong: DSDT table: Reserved MMIO space for FCH
    -----------------------
    
    Change-Id: Icc1e6d7790a24cb0b77ca2ed400ad99f09a806de
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 src/mainboard/amd/bettong/acpi/carrizo_fch.asl | 101 -------------------------
 src/mainboard/amd/bettong/dsdt.asl             |   3 -
 2 files changed, 104 deletions(-)

diff --git a/src/mainboard/amd/bettong/acpi/carrizo_fch.asl b/src/mainboard/amd/bettong/acpi/carrizo_fch.asl
deleted file mode 100644
index 5bfb366..0000000
--- a/src/mainboard/amd/bettong/acpi/carrizo_fch.asl
+++ /dev/null
@@ -1,101 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2015 Advanced Micro Devices, Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc.
- */
-
-Device(GPIO) {
-	Name (_HID, "AMD0030")
-	Name (_CID, "AMD0030")
-	Name(_UID, 0)
-
-	Method (_CRS, 0x0, NotSerialized) {
-		Name (RBUF, ResourceTemplate () {
-			//
-			// Interrupt resource. In this example, banks 0 & 1 share the same
-			// interrupt to the parent controller and similarly banks 2 & 3.
-			//
-			// N.B. The definition below is chosen for an arbitrary
-			//      test platform. It needs to be changed to reflect the hardware
-			//      configuration of the actual platform
-			//
-			Interrupt(ResourceConsumer, Level, ActiveLow, Shared, , , ) {7}
-
-			//
-			// Memory resource. The definition below is chosen for an arbitrary
-			// test platform. It needs to be changed to reflect the hardware
-			// configuration of the actual platform.
-			//
-			Memory32Fixed(ReadWrite, 0xFED81500, 0x300)
-		})
-
-		Return (RBUF)
-	}
-
-	Method (_STA, 0x0, NotSerialized) {
-			Return (0x0F)
-	}
-}
-
-Device(FUR0) {
-	Name(_HID,"AMD0020")
-	Name(_UID,0x0)
-	Name(_CRS, ResourceTemplate() {
-		IRQ(Edge, ActiveHigh, Exclusive) {10}
-		Memory32Fixed(ReadWrite, 0xFEDC6000, 0x2000)
-	})
-	Method (_STA, 0x0, NotSerialized) {
-		Return (0x0F)
-	}
-}
-
-Device(FUR1) {
-	Name(_HID,"AMD0020")
-	Name(_UID,0x1)
-	Name(_CRS, ResourceTemplate() {
-			IRQ(Edge, ActiveHigh, Exclusive) {11}
-			Memory32Fixed(ReadWrite, 0xFEDC8000, 0x2000)
-	})
-	Method (_STA, 0x0, NotSerialized) {
-			Return (0x0F)
-	}
-}
-
-Device(I2CA) {
-	Name(_HID,"AMD0010")
-	Name(_UID,0x0)
-	Name(_CRS, ResourceTemplate() {
-		IRQ(Edge, ActiveHigh, Exclusive) {3}
-		Memory32Fixed(ReadWrite, 0xFEDC2000, 0x1000)
-	})
-
-	Method (_STA, 0x0, NotSerialized) {
-		Return (0x0F)
-	}
-}
-
-Device(I2CB)
-{
-	Name(_HID,"AMD0010")
-	Name(_UID,0x1)
-	Name(_CRS, ResourceTemplate() {
-		IRQ(Edge, ActiveHigh, Exclusive) {15}
-		Memory32Fixed(ReadWrite, 0xFEDC3000, 0x1000)
-	})
-	Method (_STA, 0x0, NotSerialized) {
-		Return (0x0F)
-	}
-}
diff --git a/src/mainboard/amd/bettong/dsdt.asl b/src/mainboard/amd/bettong/dsdt.asl
index 2e6c96c..888d5cd 100644
--- a/src/mainboard/amd/bettong/dsdt.asl
+++ b/src/mainboard/amd/bettong/dsdt.asl
@@ -69,9 +69,6 @@ DefinitionBlock (
 		/* Describe PCI INT[A-H] for the Southbridge */
 		#include <southbridge/amd/pi/hudson/acpi/pci_int.asl>
 
-		/* Describe the devices in the Southbridge */
-		#include "acpi/carrizo_fch.asl"
-
 	} /* End \_SB scope */
 
 	/* Describe SMBUS for the Southbridge */