[coreboot-gerrit] New patch to review for coreboot: ACPI: Fix IASL Warning about unused method for _OSI check

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Dec 9 01:00:16 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12692

-gerrit

commit 8b061ed4969a3cad26342a2db16aa8c07fc6f1a4
Author: Martin Roth <martinroth at google.com>
Date:   Tue Dec 8 15:04:23 2015 -0700

    ACPI: Fix IASL Warning about unused method for _OSI check
    
    According to the ACPI Spec for CondRefOf, the result argument is
    optional.  In all of these locations, it was getting set but not
    used, creating a warning in new versions of IASL.  Since it's
    an optional argument, just remove it.
    
    dsdt.aml     22:   if(CondRefOf(\_OSI,Local1))
    Warning  3144 -                           ^
    Method Local is set but never used (Local1)
    
    Change-Id: I07f49ac5a3708838d1c4a7216dfb11acc415c881
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/mainboard/advansus/a785e-i/dsdt.asl              | 2 +-
 src/mainboard/amd/bimini_fam10/dsdt.asl              | 2 +-
 src/mainboard/amd/dbm690t/dsdt.asl                   | 2 +-
 src/mainboard/amd/inagua/acpi/mainboard.asl          | 2 +-
 src/mainboard/amd/mahogany/dsdt.asl                  | 2 +-
 src/mainboard/amd/mahogany_fam10/dsdt.asl            | 2 +-
 src/mainboard/amd/persimmon/acpi/mainboard.asl       | 2 +-
 src/mainboard/amd/pistachio/dsdt.asl                 | 2 +-
 src/mainboard/amd/south_station/acpi/mainboard.asl   | 2 +-
 src/mainboard/amd/tilapia_fam10/dsdt.asl             | 2 +-
 src/mainboard/amd/union_station/acpi/mainboard.asl   | 2 +-
 src/mainboard/asrock/e350m1/acpi/mainboard.asl       | 2 +-
 src/mainboard/asus/m4a78-em/dsdt.asl                 | 2 +-
 src/mainboard/asus/m4a785-m/dsdt.asl                 | 2 +-
 src/mainboard/asus/m4a785t-m/dsdt.asl                | 2 +-
 src/mainboard/asus/m5a88-v/dsdt.asl                  | 2 +-
 src/mainboard/avalue/eax-785e/dsdt.asl               | 2 +-
 src/mainboard/gigabyte/ma785gm/dsdt.asl              | 2 +-
 src/mainboard/gigabyte/ma785gmt/dsdt.asl             | 2 +-
 src/mainboard/gigabyte/ma78gm/dsdt.asl               | 2 +-
 src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl   | 2 +-
 src/mainboard/iei/kino-780am2-fam10/dsdt.asl         | 2 +-
 src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl | 2 +-
 src/mainboard/jetway/pa78vm5/dsdt.asl                | 2 +-
 src/mainboard/kontron/kt690/dsdt.asl                 | 2 +-
 src/mainboard/lenovo/x201/acpi/platform.asl          | 2 +-
 src/mainboard/lippert/frontrunner-af/dsdt.asl        | 2 +-
 src/mainboard/lippert/toucan-af/dsdt.asl             | 2 +-
 src/mainboard/packardbell/ms2290/acpi/platform.asl   | 2 +-
 src/mainboard/pcengines/apu1/acpi/mainboard.asl      | 2 +-
 src/mainboard/siemens/sitemp_g1p1/acpi/platform.asl  | 4 ++--
 src/mainboard/supermicro/h8qgi/dsdt.asl              | 2 +-
 src/mainboard/supermicro/h8scm/dsdt.asl              | 2 +-
 src/mainboard/supermicro/h8scm_fam10/dsdt.asl        | 2 +-
 src/mainboard/technexion/tim5690/dsdt.asl            | 2 +-
 src/mainboard/technexion/tim8690/dsdt.asl            | 2 +-
 src/mainboard/tyan/s8226/dsdt.asl                    | 2 +-
 src/southbridge/amd/agesa/hudson/acpi/fch.asl        | 2 +-
 src/southbridge/amd/pi/hudson/acpi/fch.asl           | 2 +-
 src/southbridge/intel/common/acpi/platform.asl       | 2 +-
 40 files changed, 41 insertions(+), 41 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/dsdt.asl b/src/mainboard/advansus/a785e-i/dsdt.asl
index f6005cd..03fc82d 100644
--- a/src/mainboard/advansus/a785e-i/dsdt.asl
+++ b/src/mainboard/advansus/a785e-i/dsdt.asl
@@ -410,7 +410,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/amd/bimini_fam10/dsdt.asl b/src/mainboard/amd/bimini_fam10/dsdt.asl
index 39332b8..ec1e60e 100644
--- a/src/mainboard/amd/bimini_fam10/dsdt.asl
+++ b/src/mainboard/amd/bimini_fam10/dsdt.asl
@@ -410,7 +410,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/amd/dbm690t/dsdt.asl b/src/mainboard/amd/dbm690t/dsdt.asl
index a4bb5d8..46d3671 100644
--- a/src/mainboard/amd/dbm690t/dsdt.asl
+++ b/src/mainboard/amd/dbm690t/dsdt.asl
@@ -374,7 +374,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/amd/inagua/acpi/mainboard.asl b/src/mainboard/amd/inagua/acpi/mainboard.asl
index 57a414e..b666a4f 100644
--- a/src/mainboard/amd/inagua/acpi/mainboard.asl
+++ b/src/mainboard/amd/inagua/acpi/mainboard.asl
@@ -35,7 +35,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/amd/mahogany/dsdt.asl b/src/mainboard/amd/mahogany/dsdt.asl
index 9ea78b6..5602368 100644
--- a/src/mainboard/amd/mahogany/dsdt.asl
+++ b/src/mainboard/amd/mahogany/dsdt.asl
@@ -373,7 +373,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/amd/mahogany_fam10/dsdt.asl b/src/mainboard/amd/mahogany_fam10/dsdt.asl
index d334f1a..afc3823 100644
--- a/src/mainboard/amd/mahogany_fam10/dsdt.asl
+++ b/src/mainboard/amd/mahogany_fam10/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/amd/persimmon/acpi/mainboard.asl b/src/mainboard/amd/persimmon/acpi/mainboard.asl
index 57a414e..b666a4f 100644
--- a/src/mainboard/amd/persimmon/acpi/mainboard.asl
+++ b/src/mainboard/amd/persimmon/acpi/mainboard.asl
@@ -35,7 +35,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/amd/pistachio/dsdt.asl b/src/mainboard/amd/pistachio/dsdt.asl
index 20fa1cd..6322289 100644
--- a/src/mainboard/amd/pistachio/dsdt.asl
+++ b/src/mainboard/amd/pistachio/dsdt.asl
@@ -374,7 +374,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/amd/south_station/acpi/mainboard.asl b/src/mainboard/amd/south_station/acpi/mainboard.asl
index 57a414e..b666a4f 100644
--- a/src/mainboard/amd/south_station/acpi/mainboard.asl
+++ b/src/mainboard/amd/south_station/acpi/mainboard.asl
@@ -35,7 +35,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/amd/tilapia_fam10/dsdt.asl b/src/mainboard/amd/tilapia_fam10/dsdt.asl
index b0545bc..daf912d 100644
--- a/src/mainboard/amd/tilapia_fam10/dsdt.asl
+++ b/src/mainboard/amd/tilapia_fam10/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/amd/union_station/acpi/mainboard.asl b/src/mainboard/amd/union_station/acpi/mainboard.asl
index 57a414e..b666a4f 100644
--- a/src/mainboard/amd/union_station/acpi/mainboard.asl
+++ b/src/mainboard/amd/union_station/acpi/mainboard.asl
@@ -35,7 +35,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/asrock/e350m1/acpi/mainboard.asl b/src/mainboard/asrock/e350m1/acpi/mainboard.asl
index 57a414e..b666a4f 100644
--- a/src/mainboard/asrock/e350m1/acpi/mainboard.asl
+++ b/src/mainboard/asrock/e350m1/acpi/mainboard.asl
@@ -35,7 +35,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl
index 815d826..28c8c4a 100644
--- a/src/mainboard/asus/m4a78-em/dsdt.asl
+++ b/src/mainboard/asus/m4a78-em/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl
index 815d826..28c8c4a 100644
--- a/src/mainboard/asus/m4a785-m/dsdt.asl
+++ b/src/mainboard/asus/m4a785-m/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/asus/m4a785t-m/dsdt.asl b/src/mainboard/asus/m4a785t-m/dsdt.asl
index 9736761..6adb8ca 100644
--- a/src/mainboard/asus/m4a785t-m/dsdt.asl
+++ b/src/mainboard/asus/m4a785t-m/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/asus/m5a88-v/dsdt.asl b/src/mainboard/asus/m5a88-v/dsdt.asl
index fb74634..f9a1758 100644
--- a/src/mainboard/asus/m5a88-v/dsdt.asl
+++ b/src/mainboard/asus/m5a88-v/dsdt.asl
@@ -410,7 +410,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/avalue/eax-785e/dsdt.asl b/src/mainboard/avalue/eax-785e/dsdt.asl
index d99e0a0..fd29b80 100644
--- a/src/mainboard/avalue/eax-785e/dsdt.asl
+++ b/src/mainboard/avalue/eax-785e/dsdt.asl
@@ -410,7 +410,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl
index aa3f6d6..091d08e 100644
--- a/src/mainboard/gigabyte/ma785gm/dsdt.asl
+++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl
index aa3f6d6..091d08e 100644
--- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl
+++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl
index aa3f6d6..091d08e 100644
--- a/src/mainboard/gigabyte/ma78gm/dsdt.asl
+++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl b/src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl
index 10cf730..4ee8efc 100644
--- a/src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl
+++ b/src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl
@@ -36,7 +36,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
index 3591617..09ce655 100644
--- a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
+++ b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl
index 57a414e..b666a4f 100644
--- a/src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl
+++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/mainboard.asl
@@ -35,7 +35,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl
index 3a75920..507ef3b 100644
--- a/src/mainboard/jetway/pa78vm5/dsdt.asl
+++ b/src/mainboard/jetway/pa78vm5/dsdt.asl
@@ -415,7 +415,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/kontron/kt690/dsdt.asl b/src/mainboard/kontron/kt690/dsdt.asl
index c230718..5884e74 100644
--- a/src/mainboard/kontron/kt690/dsdt.asl
+++ b/src/mainboard/kontron/kt690/dsdt.asl
@@ -374,7 +374,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/lenovo/x201/acpi/platform.asl b/src/mainboard/lenovo/x201/acpi/platform.asl
index 31e9e88..3aa12e9 100644
--- a/src/mainboard/lenovo/x201/acpi/platform.asl
+++ b/src/mainboard/lenovo/x201/acpi/platform.asl
@@ -99,7 +99,7 @@ Scope(\_SB)
 		/* Let's assume we're running at least Windows 2000 */
 		Store (2000, OSYS)
 
-		If (CondRefOf(_OSI, Local0)) {
+		If (CondRefOf(_OSI)) {
 			If (_OSI("Windows 2001")) {
 				Store (2001, OSYS)
 			}
diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl
index 370c435..9e3b39c 100644
--- a/src/mainboard/lippert/frontrunner-af/dsdt.asl
+++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl
@@ -404,7 +404,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/lippert/toucan-af/dsdt.asl b/src/mainboard/lippert/toucan-af/dsdt.asl
index 1bf67b5..8623aae 100644
--- a/src/mainboard/lippert/toucan-af/dsdt.asl
+++ b/src/mainboard/lippert/toucan-af/dsdt.asl
@@ -404,7 +404,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/packardbell/ms2290/acpi/platform.asl b/src/mainboard/packardbell/ms2290/acpi/platform.asl
index 4d5b5c0..9812d14 100644
--- a/src/mainboard/packardbell/ms2290/acpi/platform.asl
+++ b/src/mainboard/packardbell/ms2290/acpi/platform.asl
@@ -96,7 +96,7 @@ Scope(\_SB)
 		/* Let's assume we're running at least Windows 2000 */
 		Store (2000, OSYS)
 
-		If (CondRefOf(_OSI, Local0)) {
+		If (CondRefOf(_OSI)) {
 			If (_OSI("Windows 2001")) {
 				Store (2001, OSYS)
 			}
diff --git a/src/mainboard/pcengines/apu1/acpi/mainboard.asl b/src/mainboard/pcengines/apu1/acpi/mainboard.asl
index 57a414e..b666a4f 100644
--- a/src/mainboard/pcengines/apu1/acpi/mainboard.asl
+++ b/src/mainboard/pcengines/apu1/acpi/mainboard.asl
@@ -35,7 +35,7 @@ Scope(\_SB) {
 
 		if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-		if(CondRefOf(\_OSI,Local1))
+		if(CondRefOf(\_OSI))
 		{
 			Store(1, OSVR)					/* Assume some form of XP */
 			if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/mainboard/siemens/sitemp_g1p1/acpi/platform.asl b/src/mainboard/siemens/sitemp_g1p1/acpi/platform.asl
index 3dbc3f2..bda467a 100644
--- a/src/mainboard/siemens/sitemp_g1p1/acpi/platform.asl
+++ b/src/mainboard/siemens/sitemp_g1p1/acpi/platform.asl
@@ -36,7 +36,7 @@ Scope(\_SB)
 	{
 		Store (2000, OSYS)
 
-		If (CondRefOf(_OSI, Local0)) {
+		If (CondRefOf(_OSI)) {
 
 			If (_OSI("Linux")) {
 				Store (1, LINX)
@@ -59,4 +59,4 @@ Scope(\_SB)
 			}
 		}
 	}
-}
\ No newline at end of file
+}
diff --git a/src/mainboard/supermicro/h8qgi/dsdt.asl b/src/mainboard/supermicro/h8qgi/dsdt.asl
index 04393ae..8395c7b 100644
--- a/src/mainboard/supermicro/h8qgi/dsdt.asl
+++ b/src/mainboard/supermicro/h8qgi/dsdt.asl
@@ -456,7 +456,7 @@ DefinitionBlock (
 	Scope(\_SB) {
 		Method(OSFL, 0){
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)			/* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/supermicro/h8scm/dsdt.asl b/src/mainboard/supermicro/h8scm/dsdt.asl
index e74a856..84788b8 100644
--- a/src/mainboard/supermicro/h8scm/dsdt.asl
+++ b/src/mainboard/supermicro/h8scm/dsdt.asl
@@ -448,7 +448,7 @@ DefinitionBlock (
 	Scope(\_SB) {
 		Method(OSFL, 0){
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)			/* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
index 44c013a..dfe1076 100644
--- a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
+++ b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
@@ -433,7 +433,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/technexion/tim5690/dsdt.asl b/src/mainboard/technexion/tim5690/dsdt.asl
index 3580ae8..a763bcf 100644
--- a/src/mainboard/technexion/tim5690/dsdt.asl
+++ b/src/mainboard/technexion/tim5690/dsdt.asl
@@ -374,7 +374,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/technexion/tim8690/dsdt.asl b/src/mainboard/technexion/tim8690/dsdt.asl
index 633b71f..692c02b 100644
--- a/src/mainboard/technexion/tim8690/dsdt.asl
+++ b/src/mainboard/technexion/tim8690/dsdt.asl
@@ -374,7 +374,7 @@ DefinitionBlock (
 
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)                /* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/mainboard/tyan/s8226/dsdt.asl b/src/mainboard/tyan/s8226/dsdt.asl
index bb313a3..015687e 100644
--- a/src/mainboard/tyan/s8226/dsdt.asl
+++ b/src/mainboard/tyan/s8226/dsdt.asl
@@ -448,7 +448,7 @@ DefinitionBlock (
 	Scope(\_SB) {
 		Method(OSFL, 0){
 			if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
-			if(CondRefOf(\_OSI,Local1))
+			if(CondRefOf(\_OSI))
 			{
 				Store(1, OSVR)			/* Assume some form of XP */
 				if (\_OSI("Windows 2006"))      /* Vista */
diff --git a/src/southbridge/amd/agesa/hudson/acpi/fch.asl b/src/southbridge/amd/agesa/hudson/acpi/fch.asl
index 9351059..d7cee4a 100644
--- a/src/southbridge/amd/agesa/hudson/acpi/fch.asl
+++ b/src/southbridge/amd/agesa/hudson/acpi/fch.asl
@@ -185,7 +185,7 @@ Method(OSFL, 0){
 
 	if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-	if(CondRefOf(\_OSI,Local1))
+	if(CondRefOf(\_OSI))
 	{
 		Store(1, OSVR)					/* Assume some form of XP */
 		if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/southbridge/amd/pi/hudson/acpi/fch.asl b/src/southbridge/amd/pi/hudson/acpi/fch.asl
index 02a272d..5a433e6 100644
--- a/src/southbridge/amd/pi/hudson/acpi/fch.asl
+++ b/src/southbridge/amd/pi/hudson/acpi/fch.asl
@@ -167,7 +167,7 @@ Method(OSFL, 0){
 
 	if(LNotEqual(OSVR, Ones)) {Return(OSVR)}	/* OS version was already detected */
 
-	if(CondRefOf(\_OSI,Local1))
+	if(CondRefOf(\_OSI))
 	{
 		Store(1, OSVR)					/* Assume some form of XP */
 		if (\_OSI("Windows 2006"))		/* Vista */
diff --git a/src/southbridge/intel/common/acpi/platform.asl b/src/southbridge/intel/common/acpi/platform.asl
index 8481dfd..ba8091d 100644
--- a/src/southbridge/intel/common/acpi/platform.asl
+++ b/src/southbridge/intel/common/acpi/platform.asl
@@ -70,7 +70,7 @@ Method(GOS, 0)
 	/* Let's assume we're running at least Windows 2000 */
 	Store (2000, OSYS)
 
-	If (CondRefOf(_OSI, Local0)) {
+	If (CondRefOf(_OSI)) {
 		/* Linux answers _OSI with "True" for a couple of
 		 * Windows version queries. But unlike Windows it
 		 * needs a Video repost, so let's determine whether



More information about the coreboot-gerrit mailing list