[coreboot-gerrit] New patch to review for coreboot: ACPI: Fix IASL Warning about unused method for GBUF check

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12694

-gerrit

commit 6488b7dae8799992adc2d3098cd7dff2b3bd483f
Author: Martin Roth <martinroth at google.com>
Date:   Tue Dec 8 15:26:03 2015 -0700

    ACPI: Fix IASL Warning about unused method for GBUF check
    
    According to the ACPI Spec for CondRefOf, the result argument is
    optional.  In all of these locations, it was getting set but not
    used, creating a warning in new versions of IASL.  Since it's
    an optional argument, just remove it.
    
    dsdt.aml 640:              If (CondRefOf (^GBUF, Local0)) {
    Warning  3144 - Method Local is set but never used ^  (Local0)
    
    Change-Id: Ie2f46808e92c309a63ba7661bcbd77402a08366a
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/soc/intel/baytrail/acpi/lpe.asl     | 2 +-
 src/soc/intel/braswell/acpi/lpe.asl     | 2 +-
 src/soc/intel/fsp_baytrail/acpi/lpe.asl | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/soc/intel/baytrail/acpi/lpe.asl b/src/soc/intel/baytrail/acpi/lpe.asl
index a8ebc35..1f13fe5 100644
--- a/src/soc/intel/baytrail/acpi/lpe.asl
+++ b/src/soc/intel/baytrail/acpi/lpe.asl
@@ -68,7 +68,7 @@ Device (LPEA)
 		Store (\LPFW, BAS2)
 
 		/* Append any Mainboard defined GPIOs */
-		If (CondRefOf (^GBUF, Local0)) {
+		If (CondRefOf (^GBUF)) {
 			ConcatenateResTemplate (^RBUF, ^GBUF, Local1)
 			Return (Local1)
 		}
diff --git a/src/soc/intel/braswell/acpi/lpe.asl b/src/soc/intel/braswell/acpi/lpe.asl
index b213fe6..6dd73ab 100644
--- a/src/soc/intel/braswell/acpi/lpe.asl
+++ b/src/soc/intel/braswell/acpi/lpe.asl
@@ -68,7 +68,7 @@ Device (LPEA)
 		Store (\LPFW, BAS2)
 
 		/* Append any Mainboard defined GPIOs */
-		If (CondRefOf (^GBUF, Local0)) {
+		If (CondRefOf (^GBUF)) {
 			ConcatenateResTemplate (^RBUF, ^GBUF, Local1)
 			Return (Local1)
 		}
diff --git a/src/soc/intel/fsp_baytrail/acpi/lpe.asl b/src/soc/intel/fsp_baytrail/acpi/lpe.asl
index d1dbd3a..1f13fe5 100644
--- a/src/soc/intel/fsp_baytrail/acpi/lpe.asl
+++ b/src/soc/intel/fsp_baytrail/acpi/lpe.asl
@@ -68,8 +68,8 @@ Device (LPEA)
 		Store (\LPFW, BAS2)
 
 		/* Append any Mainboard defined GPIOs */
-		If (CondRefOf (^GBUF, Local0)) {
-			ConcatenateResTemplate (^RBUF, Local0, Local1)
+		If (CondRefOf (^GBUF)) {
+			ConcatenateResTemplate (^RBUF, ^GBUF, Local1)
 			Return (Local1)
 		}