[coreboot-gerrit] New patch to review for coreboot: intel/fsp_baytrail: Fix PCI_DEV_PIRQ_ROUTE macro ending

Ben Gardner (gardner.ben@gmail.com) gerrit at coreboot.org
Wed Dec 9 18:18:43 CET 2015


Ben Gardner (gardner.ben at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12696

-gerrit

commit da0f1847c566525e7758bfefcb2ba0a10b9544a5
Author: Ben Gardner <gardner.ben at gmail.com>
Date:   Wed Dec 9 11:17:51 2015 -0600

    intel/fsp_baytrail: Fix PCI_DEV_PIRQ_ROUTE macro ending
    
    The macro PCI_DEV_PIRQ_ROUTE ends with a comma and escaped newline.
    Ending a macro with an escaped newline is always wrong.
    The final comma is not necessary, as all uses of PCI_DEV_PIRQ_ROUTE()
    properly separate calls with a comma.
    
    I haven't investigated whether this is causing a real issue, but it should
    be leaving gaps in struct baytrail_irq_route.pcidev.
    
    The non-FSP baytrail does not have this issue.
    
    Change-Id: If6782176068b07cb3bc819c00d1cdb1b618bcea8
    Signed-off-by: Ben Gardner <gardner.ben at gmail.com>
---
 src/soc/intel/fsp_baytrail/acpi/irq_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/fsp_baytrail/acpi/irq_helper.h b/src/soc/intel/fsp_baytrail/acpi/irq_helper.h
index a8cf3ef..8d18aea 100644
--- a/src/soc/intel/fsp_baytrail/acpi/irq_helper.h
+++ b/src/soc/intel/fsp_baytrail/acpi/irq_helper.h
@@ -85,7 +85,7 @@ Name(prefix_ ## func_ ## A, Package() \
 	ACPI_DEV_IRQ(dev_, 0, a_), \
 	ACPI_DEV_IRQ(dev_, 1, b_), \
 	ACPI_DEV_IRQ(dev_, 2, c_), \
-	ACPI_DEV_IRQ(dev_, 3, d_), \
+	ACPI_DEV_IRQ(dev_, 3, d_)
 
 #define PCIE_BRIDGE_DEV(prefix_, dev_, a_, b_, c_, d_) \
 	ROOTPORT_IRQ_ROUTES(prefix_, a_, b_, c_, d_) \



More information about the coreboot-gerrit mailing list