[coreboot-gerrit] Patch set updated for coreboot: northbridge/intel ACPI: Remove unused Local method

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Fri Dec 11 00:56:45 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12706

-gerrit

commit 83fdbdd0b4214519bf1d5621fb92794cde4d495a
Author: Martin Roth <martinroth at google.com>
Date:   Thu Dec 10 08:28:53 2015 -0700

    northbridge/intel ACPI: Remove unused Local method
    
    The remainder of the divide operation was being placed into a Local,
    but was never being used, causing an IASL warning.  Since this
    field is optional, just remove the Local.
    
    Fixes IASL warning:
    dsdt.aml 640:Divide (Multiply (CTDN, 125), 100, Local0, PL2V)
    Warning  3144 - Method Local is set but never used ^  (Local0)
    
    Change-Id: I0b43ef638b1bc3e1163c45f31f8da57aa0d39e22
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/northbridge/intel/fsp_sandybridge/acpi/hostbridge.asl | 4 ++--
 src/northbridge/intel/nehalem/acpi/hostbridge.asl         | 4 ++--
 src/northbridge/intel/sandybridge/acpi/hostbridge.asl     | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/northbridge/intel/fsp_sandybridge/acpi/hostbridge.asl b/src/northbridge/intel/fsp_sandybridge/acpi/hostbridge.asl
index 6c73f83..90d1b1a 100644
--- a/src/northbridge/intel/fsp_sandybridge/acpi/hostbridge.asl
+++ b/src/northbridge/intel/fsp_sandybridge/acpi/hostbridge.asl
@@ -185,7 +185,7 @@ Device (MCHC)
 		PPCN ()
 
 		/* Set PL2 to 1.25 * PL1 */
-		Divide (Multiply (CTDD, 125), 100, Local0, PL2V)
+		Divide (Multiply (CTDD, 125), 100, , PL2V)
 
 		/* Set PL1 */
 		Store (CTDD, PL1V)
@@ -214,7 +214,7 @@ Device (MCHC)
 		Store (CTDN, PL1V)
 
 		/* Set PL2 to 1.25 * PL1 */
-		Divide (Multiply (CTDN, 125), 100, Local0, PL2V)
+		Divide (Multiply (CTDN, 125), 100, , PL2V)
 
 		/* Set PPC limit and notify OS */
 		Store (PSSS (TARN), PPCM)
diff --git a/src/northbridge/intel/nehalem/acpi/hostbridge.asl b/src/northbridge/intel/nehalem/acpi/hostbridge.asl
index df8424d..337a9bc 100644
--- a/src/northbridge/intel/nehalem/acpi/hostbridge.asl
+++ b/src/northbridge/intel/nehalem/acpi/hostbridge.asl
@@ -147,7 +147,7 @@ Device (MCHC)
 		PPCN ()
 
 		/* Set PL2 to 1.25 * PL1 */
-		Divide (Multiply (CTDD, 125), 100, Local0, PL2V)
+		Divide (Multiply (CTDD, 125), 100, , PL2V)
 
 		/* Set PL1 */
 		Store (CTDD, PL1V)
@@ -176,7 +176,7 @@ Device (MCHC)
 		Store (CTDN, PL1V)
 
 		/* Set PL2 to 1.25 * PL1 */
-		Divide (Multiply (CTDN, 125), 100, Local0, PL2V)
+		Divide (Multiply (CTDN, 125), 100, , PL2V)
 
 		/* Set PPC limit and notify OS */
 		Store (PSSS (TARN), PPCM)
diff --git a/src/northbridge/intel/sandybridge/acpi/hostbridge.asl b/src/northbridge/intel/sandybridge/acpi/hostbridge.asl
index a45d37a..5988489 100644
--- a/src/northbridge/intel/sandybridge/acpi/hostbridge.asl
+++ b/src/northbridge/intel/sandybridge/acpi/hostbridge.asl
@@ -185,7 +185,7 @@ Device (MCHC)
 		PPCN ()
 
 		/* Set PL2 to 1.25 * PL1 */
-		Divide (Multiply (CTDD, 125), 100, Local0, PL2V)
+		Divide (Multiply (CTDD, 125), 100, , PL2V)
 
 		/* Set PL1 */
 		Store (CTDD, PL1V)
@@ -214,7 +214,7 @@ Device (MCHC)
 		Store (CTDN, PL1V)
 
 		/* Set PL2 to 1.25 * PL1 */
-		Divide (Multiply (CTDN, 125), 100, Local0, PL2V)
+		Divide (Multiply (CTDN, 125), 100, , PL2V)
 
 		/* Set PPC limit and notify OS */
 		Store (PSSS (TARN), PPCM)



More information about the coreboot-gerrit mailing list