[coreboot-gerrit] Patch set updated for coreboot: build system/x86: depend on directories before touch /empty targets

Alexander Couzens (lynxis@fe80.eu) gerrit at coreboot.org
Mon Dec 14 22:20:27 CET 2015


Alexander Couzens (lynxis at fe80.eu) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12717

-gerrit

commit ac85f74c761285fd732e04fd9021c388367b65e9
Author: Alexander Couzens <lynxis at fe80.eu>
Date:   Mon Dec 14 22:04:54 2015 +0100

    build system/x86: depend on directories before touch /empty targets
    
    $(objgenerated)/empty would touch files before the directory
    is created on parallel builds.
    
    Thanks to reproducible-builds.org for hitting this bug.
    
    Change-Id: I7565e9fe130b4e9deaf1c7b9d568ff90b00dda52
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 src/arch/x86/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index d552aa2..9713d52 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -87,7 +87,7 @@ bootblock_romccflags := -mcpu=k7 -msse -O2 -D__PRE_RAM__ -D__BOOTBLOCK__
 endif
 
 # This is a hack in case there are no per chipset linker files.
-$(objgenerated)/empty:
+$(objgenerated)/empty: build-dirs
 	touch $@
 
 $(objgenerated)/bootblock.ld: $$(filter-out $(obj)/arch/x86/bootblock.bootblock.ld, $$(filter %.ld,$$(bootblock-objs))) $(objgenerated)/empty



More information about the coreboot-gerrit mailing list