[coreboot-gerrit] Patch merged into coreboot/master: intel/fsp_baytrail: Fix PCI_DEV_PIRQ_ROUTE macro ending

gerrit at coreboot.org gerrit at coreboot.org
Wed Dec 16 00:53:50 CET 2015


the following patch was just integrated into master:
commit 49bbfcd5d393b8c14b46e46f0b20f150e4930b3d
Author: Ben Gardner <gardner.ben at gmail.com>
Date:   Wed Dec 9 11:17:51 2015 -0600

    intel/fsp_baytrail: Fix PCI_DEV_PIRQ_ROUTE macro ending
    
    The macro PCI_DEV_PIRQ_ROUTE ends with a comma and escaped newline.
    Ending a macro with an escaped newline is always wrong.
    The final comma is not necessary, as all uses of PCI_DEV_PIRQ_ROUTE()
    properly separate calls with a comma.
    
    I haven't investigated whether this is causing a real issue, but it should
    be leaving gaps in struct baytrail_irq_route.pcidev.
    
    The non-FSP baytrail does not have this issue.
    
    Change-Id: If6782176068b07cb3bc819c00d1cdb1b618bcea8
    Signed-off-by: Ben Gardner <gardner.ben at gmail.com>
    Reviewed-on: https://review.coreboot.org/12696
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-by: Werner Zeh <werner.zeh at siemens.com>


See https://review.coreboot.org/12696 for details.

-gerrit



More information about the coreboot-gerrit mailing list