[coreboot-gerrit] Patch merged into coreboot/master: cpu/allwinner/a10: Fix I2c speed calculation

gerrit at coreboot.org gerrit at coreboot.org
Fri Dec 25 21:51:27 CET 2015


the following patch was just integrated into master:
commit 0fa4f6f23d6bec4216e0be27526a009db50c8938
Author: Martin Roth <martinroth at google.com>
Date:   Mon Dec 21 12:51:40 2015 -0700

    cpu/allwinner/a10: Fix I2c speed calculation
    
    Looking at the A10 datasheet, N should go in bits 2:0, but
    was being cleared by shifting it left by three bits, then
    anding it with 7.
    
    Fixes coverity warning:
    CID 1241888 (#1 of 1): Wrong operator used (CONSTANT_EXPRESSION_RESULT)
    operator_confusion: (n << 3) & (7U /* 7 << 0 */) is always 0 regardless
    of the values of its operands. This occurs as the bitwise second operand
    of '|'.
    
    Change-Id: I17e71a73adf37a62607e8e5865b1da749d7278aa
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/12779
    Tested-by: build bot (Jenkins)
    Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/12779 for details.

-gerrit



More information about the coreboot-gerrit mailing list