[coreboot-gerrit] New patch to review for coreboot: Kconfig: move fmap description file prompt into general setup

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Sun Dec 27 01:04:22 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12805

-gerrit

commit 77d7408df61927dea0957cb8e88c42de0dc428a4
Author: Martin Roth <gaumless at gmail.com>
Date:   Sat Dec 26 16:51:16 2015 -0700

    Kconfig: move fmap description file prompt into general setup
    
    Split up the prompt and setting the default so that the prompt can go
    in the general setup menu but still have the default set in the
    mainboard Kconfig files.
    
    Change-Id: I52fba5ced869d51d10065f8c9ebd258d3a1d4156
    Signed-off-by: Martin Roth <gaumless at gmail.com>
---
 src/Kconfig | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/Kconfig b/src/Kconfig
index 38cf855..6069d42 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -347,6 +347,14 @@ config BOOTSPLASH_FILE
 	  The path and filename of the file to use as graphical bootsplash
 	  screen. The file format has to be jpg.
 
+# default is set at the end of the file so it can be overriden in the maiboards
+config FMDFILE
+	string "fmap description file in fmd format"
+	help
+	  The build system creates a default FMAP from ROM_SIZE and CBFS_SIZE,
+	  but in some cases more complex setups are required.
+	  When an fmd is specified, it overrides the default format.
+
 endmenu
 
 source "src/acpi/Kconfig"
@@ -376,14 +384,6 @@ config CBFS_SIZE
 
 endmenu
 
-config FMDFILE
-	string "fmap description file in fmd format"
-	default ""
-	help
-	  The build system creates a default FMAP from ROM_SIZE and CBFS_SIZE,
-	  but in some cases more complex setups are required.
-	  When an fmd is specified, it overrides the default format.
-
 config SYSTEM_TYPE_LAPTOP
 	default n
 	bool
@@ -1153,3 +1153,8 @@ config MAX_REBOOT_CNT
 	  Internal option that sets the maximum number of bootblock executions allowed
 	  with the normal image enabled before assuming the normal image is defective
 	  and switching to the fallback image.
+
+# Set defaults at the end so that the prompts can go where we want them
+config FMDFILE
+	string
+	default ""



More information about the coreboot-gerrit mailing list