[coreboot-gerrit] Patch set updated for coreboot: xcompile: Remove warnings about missing tools & architectures

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Dec 30 23:55:05 CET 2015


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12682

-gerrit

commit 8fdfefb256483b7e98d52994241b79299a3aed7f
Author: Martin Roth <martinroth at google.com>
Date:   Mon Dec 7 14:34:46 2015 -0700

    xcompile: Remove warnings about missing tools & architectures
    
    Let toolchain.inc error out when the architecture or tool is missing.
    
    Change-Id: I39a51e5a2c778d6bbc50354807e5e2b717fa9e52
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/xcompile/xcompile | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 635bcd6..afd5986 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -56,8 +56,6 @@ if [ "$(${XGCCPATH}/iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then
 	IASL=${XGCCPATH}iasl
 elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then
 	IASL=iasl
-else
-	die "no iasl found"
 fi
 
 if program_exists gcc; then
@@ -350,19 +348,13 @@ test_architecture() {
 		# that this will change in the future.
 		CLANG="clang -target ${clang_arch}-${TABI} -ccc-gcc-name ${GCC}"
 	fi
-
-	if [ -z "$GCC" -a -z "$CLANG" -a "power8" != "$architecture" ]; then
-		echo "Warning: no suitable compiler for $architecture." >&2
-		return 1
-	fi
 }
 
 # This loops over all supported architectures.
 for architecture in $SUPPORTED_ARCHITECTURES; do
-	if test_architecture $architecture; then
-		detect_special_flags "$architecture"
-		detect_compiler_runtime "$architecture"
-		report_arch_toolchain
-	fi
+	test_architecture $architecture
+	detect_special_flags "$architecture"
+	detect_compiler_runtime "$architecture"
+	report_arch_toolchain
 done
 echo XCOMPILE_COMPLETE:=1



More information about the coreboot-gerrit mailing list