[coreboot-gerrit] New patch to review for coreboot: 1a71c71 AMD cimx/sb800: Disable unused GPP ports

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8385

-gerrit

commit 1a71c71eb47d2697d1d974229c2d7dfabe831bf1
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Feb 7 07:07:16 2015 +0200

    AMD cimx/sb800: Disable unused GPP ports
    
    If devicetree.cb has GPP port off, really disable it before even
    trying to do link training.
    
    Change-Id: I810945da28d86768e88249dc4d29a50ad9f9959b
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/vendorcode/amd/cimx/sb800/Gpp.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/vendorcode/amd/cimx/sb800/Gpp.c b/src/vendorcode/amd/cimx/sb800/Gpp.c
index 6f3bb7c..ae7f3ce 100644
--- a/src/vendorcode/amd/cimx/sb800/Gpp.c
+++ b/src/vendorcode/amd/cimx/sb800/Gpp.c
@@ -293,7 +293,10 @@ PreInitGppLink (
 
   // Mask out non-applicable ports according to the target link configuration mode
   for ( portId = 0; portId < MAX_GPP_PORTS; portId++ ) {
-    pConfig->PORTCONFIG[portId].PortCfg.PortPresent &= (reg32Value >> portId) & BIT0;
+    if (!(reg32Value & (1 << portId)))
+      pConfig->PORTCONFIG[portId].PortCfg.PortPresent = false;
+    else if (!pConfig->PORTCONFIG[portId].PortCfg.PortPresent)
+      reg32Value &= ~(1 << portId);
   }
 
   //