[coreboot-gerrit] New patch to review for coreboot: c30ff15 console: Fix broken early_print.h include guards
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Wed Feb 11 02:21:23 CET 2015
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8420
-gerrit
commit c30ff15661b2d02dd963d7f3c2475a7604820fcf
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date: Wed Feb 11 01:56:38 2015 +0100
console: Fix broken early_print.h include guards
Make compilation fail if this is included in non-romcc compiles.
I am a bit surprised that this ever compiled.
Change-Id: I8dfc1229681819d2381821a0195a89b44dd76b6a
Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
src/include/console/early_print.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/include/console/early_print.h b/src/include/console/early_print.h
index cbc9b46..024983d 100644
--- a/src/include/console/early_print.h
+++ b/src/include/console/early_print.h
@@ -18,11 +18,14 @@
#ifndef __CONSOLE_EARLY_PRINT_H_
#define __CONSOLE_EARLY_PRINT_H_
+#if defined(__ROMCC__)
+#error "Don't include early_print.h"
+#endif
+
#include <console/console.h>
#include <console/streams.h>
#include <console/loglevel.h>
-#if defined(__ROMCC__)
/* While in romstage, console loglevel is built-time constant.
* With ROMCC we inline this test with help from preprocessor.
*/
More information about the coreboot-gerrit
mailing list