[coreboot-gerrit] New patch to review for coreboot: dd8d0c1 device/device_util.c: Add space after ellipse for better legibility

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Thu Feb 12 00:33:36 CET 2015


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8424

-gerrit

commit dd8d0c13d829db8ec8377feae0e1a34482c90248
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Thu Feb 12 00:29:32 2015 +0100

    device/device_util.c: Add space after ellipse for better legibility
    
    Currently the coreboot console log contains messages in the following
    form.
    
    	Show all devs...Before device enumeration.
    	[…]
    	Show all devs...After init.
    
    Add a space after the ellipse, so it’s better readable and it does not
    look like a newline is missing.
    
    	Show all devs... Before device enumeration.
    	[…]
    	Show all devs... After init.
    
    Change-Id: Ifa2a37b8d60c433c219df7533a79fced03b6271a
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/device/device_util.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/device/device_util.c b/src/device/device_util.c
index d5466cb..62a815f 100644
--- a/src/device/device_util.c
+++ b/src/device/device_util.c
@@ -818,7 +818,7 @@ void show_devs_tree(struct device *dev, int debug_level, int depth, int linknum)
 void show_all_devs_tree(int debug_level, const char *msg)
 {
 	/* Bail if not printing to screen. */
-	if (!do_printk(debug_level, "Show all devs in tree form...%s\n", msg))
+	if (!do_printk(debug_level, "Show all devs in tree form... %s\n", msg))
 		return;
 	show_devs_tree(all_devices, debug_level, 0, -1);
 }
@@ -826,7 +826,7 @@ void show_all_devs_tree(int debug_level, const char *msg)
 void show_devs_subtree(struct device *root, int debug_level, const char *msg)
 {
 	/* Bail if not printing to screen. */
-	if (!do_printk(debug_level, "Show all devs in subtree %s...%s\n",
+	if (!do_printk(debug_level, "Show all devs in subtree %s... %s\n",
 		       dev_path(root), msg))
 		return;
 	do_printk(debug_level, "%s\n", msg);
@@ -838,7 +838,7 @@ void show_all_devs(int debug_level, const char *msg)
 	struct device *dev;
 
 	/* Bail if not printing to screen. */
-	if (!do_printk(debug_level, "Show all devs...%s\n", msg))
+	if (!do_printk(debug_level, "Show all devs... %s\n", msg))
 		return;
 	for (dev = all_devices; dev; dev = dev->next) {
 		do_printk(debug_level, "%s: enabled %d\n",
@@ -878,7 +878,7 @@ void show_all_devs_resources(int debug_level, const char* msg)
 {
 	struct device *dev;
 
-	if (!do_printk(debug_level, "Show all devs with resources...%s\n", msg))
+	if (!do_printk(debug_level, "Show all devs with resources... %s\n", msg))
 		return;
 
 	for (dev = all_devices; dev; dev = dev->next) {



More information about the coreboot-gerrit mailing list