[coreboot-gerrit] New patch to review for coreboot: 92a79a4 nvramcui: don't wait for the first key update to render the form

Lubomir Rintel (lkundrak@v3.sk) gerrit at coreboot.org
Tue Feb 24 20:38:57 CET 2015


Lubomir Rintel (lkundrak at v3.sk) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8526

-gerrit

commit 92a79a4e7214d591f4ac287e556422c46e95584c
Author: Lubomir Rintel <lkundrak at v3.sk>
Date:   Sun Feb 1 15:24:43 2015 +0100

    nvramcui: don't wait for the first key update to render the form
    
    Flush out the initial screen window and render the form before the first
    keypress. It looks overly weird otherwise and is very likely unintended.
    
    Change-Id: I8700e36e608f2ba115359070f75b7dc9f230291e
    Signed-off-by: Lubomir Rintel <lkundrak at v3.sk>
---
 payloads/nvramcui/nvramcui.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c
index b0ba699..6543548 100644
--- a/payloads/nvramcui/nvramcui.c
+++ b/payloads/nvramcui/nvramcui.c
@@ -81,6 +81,7 @@ int main()
 	keypad(stdscr, TRUE);
 	cbreak();
 	noecho();
+
 	start_color();
 	leaveok(stdscr, TRUE);
 	curs_set(1);
@@ -88,6 +89,7 @@ int main()
 	erase();
 	box(stdscr, 0, 0);
 	mvaddstr(0, 2, "coreboot configuration utility");
+	refresh();
 
 	/* prep CMOS layout into libcurses data structures */
 	
@@ -188,6 +190,7 @@ int main()
 
 	done = 0;
 	while(!done) {
+		render_form(form);
 		ch=getch();
 		if (ch == ERR) continue;
 		switch (ch) {
@@ -225,7 +228,6 @@ int main()
 			form_driver(form, ch);
 			break;
 		}
-		render_form(form);
 	}
 
 	for (i = 0; i < numopts; i++) {



More information about the coreboot-gerrit mailing list