[coreboot-gerrit] Patch merged into coreboot/master: 4104e6c x86: Fix pointer arithmetic regressions from MMIO changes
gerrit at coreboot.org
gerrit at coreboot.org
Fri Feb 27 18:15:36 CET 2015
the following patch was just integrated into master:
commit 4104e6cd30ba80f93e764e5036f79dd7a60d5b1c
Author: Kevin Paul Herbert <kph at meraki.net>
Date: Wed Feb 25 00:36:51 2015 -0800
x86: Fix pointer arithmetic regressions from MMIO changes
During the development of commit bde6d30 (x86: Change MMIO addr
in readN(addr)/writeN(addr, val) to pointer), there were several iterations
and patterns tried. An intermediate pattern was the use of u32 pointers,
and division by sizeof(u32). Some of these did not get properly
changed to pointer types of length 1, causing a regression in
the Intel Ibex Peak SATA driver, fixed in commit 9b5f137
(Intel ibexpeak: Fix SATA configuration).
Other regressions of this pattern are fixed here. I audited all changes
to u32 types, and the other ones are safe.
Change-Id: I9e73ac8f4329df8bf0cdd1a14759f0280f974052
Signed-off-by: Kevin Paul Herbert <kph at meraki.net>
Reviewed-on: http://review.coreboot.org/8530
Tested-by: build bot (Jenkins)
Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/8530 for details.
-gerrit
More information about the coreboot-gerrit
mailing list