[coreboot-gerrit] Patch set updated for coreboot: 741c86f northbridge/amd/agesa/family1{4, 5}: Remove cruft from dimmSpd.c

Edward O'Callaghan (eocallaghan@alterapraxis.com) gerrit at coreboot.org
Fri Jan 2 04:58:25 CET 2015


Edward O'Callaghan (eocallaghan at alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8017

-gerrit

commit 741c86f2e40b8ae4674f758114521a25f9f80831
Author: Edward O'Callaghan <eocallaghan at alterapraxis.com>
Date:   Thu Jan 1 04:09:04 2015 +1100

    northbridge/amd/agesa/family1{4,5}: Remove cruft from dimmSpd.c
    
    Remove useless comment pretaining to abusing pragma's for old
    GCC/GDB interaction issues.
    
    Change-Id: Ic83a0285ac947a23699a81a82b89de08a47ab052
    Signed-off-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
---
 src/northbridge/amd/agesa/family14/dimmSpd.c | 3 ---
 src/northbridge/amd/agesa/family15/dimmSpd.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/src/northbridge/amd/agesa/family14/dimmSpd.c b/src/northbridge/amd/agesa/family14/dimmSpd.c
index 6ca2ce1..bee2c7e 100644
--- a/src/northbridge/amd/agesa/family14/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family14/dimmSpd.c
@@ -30,9 +30,6 @@
 
 #include <northbridge/amd/agesa/dimmSpd.h>
 
-/* uncomment for source level debug - GDB gets really confused otherwise. */
-//#pragma optimize ("", off)
-
 /**
  * Gets the SMBus address for an SPD from the array in devicetree.cb
  * then read the SPD into the supplied buffer.
diff --git a/src/northbridge/amd/agesa/family15/dimmSpd.c b/src/northbridge/amd/agesa/family15/dimmSpd.c
index bf8e59e..201f293 100644
--- a/src/northbridge/amd/agesa/family15/dimmSpd.c
+++ b/src/northbridge/amd/agesa/family15/dimmSpd.c
@@ -30,9 +30,6 @@
 
 #include <northbridge/amd/agesa/dimmSpd.h>
 
-/* uncomment for source level debug - GDB gets really confused otherwise. */
-//#pragma optimize ("", off)
-
 /**
  * Gets the SMBus address for an SPD from the array in devicetree.cb
  * then read the SPD into the supplied buffer.



More information about the coreboot-gerrit mailing list