[coreboot-gerrit] New patch to review for coreboot: facd5fc nyan: Ignore the recovery GPIO.

[Marc Jones (marc.jones@se-eng.com)]

Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8042

-gerrit

commit facd5fc99b0fea5594ce29417b58d138248b4429
Author: Todd Broch <tbroch at chromium.org>
Date:   Fri Jun 6 17:03:49 2014 -0700

    nyan: Ignore the recovery GPIO.
    
    CrOS devices with Chromeos EC need only use hostevent to communicate
    recovery assertion to the BIOS.  This CL removes wired GPIO from
    determining recovery as it appears under certain conditions (cold
    reset) the internal PU on the AP isn't strong enough and therefore the
    value is sometimes seen as asserted.
    
    BRANCH=none
    BUG=chrome-os-partner:29333
    TEST=compiles & BIOS no longer responds to rec_mode GPIO during boot.
    
    Original-Change-Id: Ib220cfa5f5bfe7193d555bfd32c0444b063d00f2
    Original-Signed-off-by: Todd Broch <tbroch at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/202996
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Original-Reviewed-by: Tom Warren <twarren at nvidia.com>
    (cherry picked from commit d9927bcd67b0fb069fde231314e654d727092282)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
    
    Change-Id: I6e086cbabc884f18deb2791a0f897e332b31032f
---
 src/mainboard/google/nyan/chromeos.c       | 4 ----
 src/mainboard/google/nyan_big/chromeos.c   | 4 ----
 src/mainboard/google/nyan_blaze/chromeos.c | 4 ----
 3 files changed, 12 deletions(-)

diff --git a/src/mainboard/google/nyan/chromeos.c b/src/mainboard/google/nyan/chromeos.c
index 6377fb2..c4d98b7 100644
--- a/src/mainboard/google/nyan/chromeos.c
+++ b/src/mainboard/google/nyan/chromeos.c
@@ -84,10 +84,6 @@ int get_recovery_mode_switch(void)
 {
 	uint32_t ec_events;
 
-	/* The GPIO is active low. */
-	if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
-		return 1;
-
 	ec_events = google_chromeec_get_events_b();
 	return !!(ec_events &
 		  EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
diff --git a/src/mainboard/google/nyan_big/chromeos.c b/src/mainboard/google/nyan_big/chromeos.c
index 298fd6a..054abf6 100644
--- a/src/mainboard/google/nyan_big/chromeos.c
+++ b/src/mainboard/google/nyan_big/chromeos.c
@@ -84,10 +84,6 @@ int get_recovery_mode_switch(void)
 {
 	uint32_t ec_events;
 
-	/* The GPIO is active low. */
-	if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
-		return 1;
-
 	ec_events = google_chromeec_get_events_b();
 	return !!(ec_events &
 		  EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));
diff --git a/src/mainboard/google/nyan_blaze/chromeos.c b/src/mainboard/google/nyan_blaze/chromeos.c
index 16f0c98..da017ea 100644
--- a/src/mainboard/google/nyan_blaze/chromeos.c
+++ b/src/mainboard/google/nyan_blaze/chromeos.c
@@ -88,10 +88,6 @@ int get_recovery_mode_switch(void)
 {
 	uint32_t ec_events;
 
-	/* The GPIO is active low. */
-	if (!gpio_get_in_value(GPIO(Q7))) // RECMODE_GPIO
-		return 1;
-
 	ec_events = google_chromeec_get_events_b();
 	return !!(ec_events &
 		  EC_HOST_EVENT_MASK(EC_HOST_EVENT_KEYBOARD_RECOVERY));