[coreboot-gerrit] Patch merged into coreboot/master: c5cd57c nyan: Remove broken setup_display() from romstage
gerrit at coreboot.org
gerrit at coreboot.org
Fri Mar 13 18:43:23 CET 2015
the following patch was just integrated into master:
commit c5cd57c330694a63360be4d93ecf5cb23883aafc
Author: Julius Werner <jwerner at chromium.org>
Date: Fri Jul 11 17:09:41 2014 -0700
nyan: Remove broken setup_display() from romstage
This patch removes a chunk of romstage code from Tegra and all Nyan
boards that was supposed to enable some LCD power rails early, but never
really worked. The dev_find_slot() function can only find PCI devices,
which the CPU cluster is not. Since we're done with Nyan-RO and the
ramstage display code is fine as it is, there is no point in trying to
fix this... but we should remove it from ToT lest someone uses it as a
blueprint to add more dead code to future boards.
BRANCH=None
BUG=None
TEST=None
Original-Change-Id: I6eee256873299429d4e3934fe7d454120390f34d
Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/207720
Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
(cherry picked from commit a3df62a3bcefcc20ae59648f5d1f0a01db3c02c6)
Signed-off-by: Marc Jones <marc.jones at se-eng.com>
Change-Id: I8deedea5e9787848aae3064509c611bc349313cc
Reviewed-on: http://review.coreboot.org/8638
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: David Hendricks <dhendrix at chromium.org>
See http://review.coreboot.org/8638 for details.
-gerrit
More information about the coreboot-gerrit
mailing list