[coreboot-gerrit] Patch merged into coreboot/master: 9ef9d85 bootstate: use structure pointers for scheduling callbacks
gerrit at coreboot.org
gerrit at coreboot.org
Wed Mar 18 16:41:46 CET 2015
the following patch was just integrated into master:
commit 9ef9d85976fcfc5f4c8c273eaf3377fdd6e5c24d
Author: Aaron Durbin <adurbin at chromium.org>
Date: Mon Mar 16 17:30:09 2015 -0500
bootstate: use structure pointers for scheduling callbacks
The GCC 4.9.2 update showed that the boot_state_init_entry
structures were being padded and assumed to be aligned in to an
increased size. The bootstate scheduler for static entries,
boot_state_schedule_static_entries(), was then calculating the
wrong values within the array. To fix this just use a pointer to
the boot_state_init_entry structure that needs to be scheduled.
In addition to the previous issue noted above, the .bs_init
section was sitting in the read only portion of the image while
the fields within it need to be writable. Also, the
boot_state_schedule_static_entries() was using symbol comparison
to terminate a loop which in C can lead the compiler to always
evaluate the loop at least once since the language spec indicates
no 2 symbols can be the same value.
Change-Id: I6dc5331c2979d508dde3cd5c3332903d40d8048b
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-on: http://review.coreboot.org/8699
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/8699 for details.
-gerrit
More information about the coreboot-gerrit
mailing list