[coreboot-gerrit] New patch to review for coreboot: 9e40994 chromeec: correct response length for VBNV write
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Fri Mar 20 16:21:05 CET 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8826
-gerrit
commit 9e40994f341c6dcd91006d223de0f953ac98e9c6
Author: Aaron Durbin <adurbin at chromium.org>
Date: Wed Aug 6 14:28:52 2014 -0500
chromeec: correct response length for VBNV write
The EC doesn't return any data when one performs a write to
VBNV context. Therefore there is a mismatch of expectations.
Correct this by properly setting the expected response length.
BUG=chrome-os-partner:31148
BRANCH=None
TEST=No longer hanging while writing to VBNV on ryu.
Change-Id: I7077a507c3280358dac1f88ece62cacee9b71bea
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: c1735c3377163aeb9e90155cb9f081a1eea919c9
Original-Change-Id: I455724f20f5442bd62a792f09273227417475f07
Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/211137
Original-Reviewed-by: Stefan Reinauer <reinauer at google.com>
Original-Reviewed-by: Tom Warren <twarren at nvidia.com>
Original-Reviewed-by: Furquan Shaikh <furquan at chromium.org>
---
src/ec/google/chromeec/ec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ec/google/chromeec/ec.c b/src/ec/google/chromeec/ec.c
index 9e6e4d6..7d35a04 100644
--- a/src/ec/google/chromeec/ec.c
+++ b/src/ec/google/chromeec/ec.c
@@ -194,7 +194,7 @@ int google_chromeec_vbnv_context(int is_read, uint8_t *data, int len)
cec_cmd.cmd_data_in = &cmd_vbnvcontext;
cec_cmd.cmd_data_out = &rsp_vbnvcontext;
cec_cmd.cmd_size_in = sizeof(cmd_vbnvcontext);
- cec_cmd.cmd_size_out = sizeof(rsp_vbnvcontext);
+ cec_cmd.cmd_size_out = is_read ? sizeof(rsp_vbnvcontext) : 0;
cmd_vbnvcontext.op = is_read ? EC_VBNV_CONTEXT_OP_READ :
EC_VBNV_CONTEXT_OP_WRITE;
More information about the coreboot-gerrit
mailing list