[coreboot-gerrit] Patch merged into coreboot/master: 5142163 libpayload: cbfs: Fix ram_media map() error return value

gerrit at coreboot.org gerrit at coreboot.org
Sat Mar 21 11:04:44 CET 2015


the following patch was just integrated into master:
commit 51421633d534752c2d677a5255f9583ecdcd4a60
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Jan 6 21:34:19 2015 -0800

    libpayload: cbfs: Fix ram_media map() error return value
    
    The correct return value for errors on a cbfs_media->map() call is
    CBFS_MEDIA_INVALID_MAP_ADDRESS, not NULL. Not sure if that's the best
    choice (since 0xffffffff is probably a more likely valid address than 0
    there), but that's what the upper layers expect right now.
    
    BRANCH=veyron
    BUG=None
    TEST=Press CTRL+L with an RW_LEGACY section filled with 0xff. Observe
    how cbfs_get_header() returns failure without doing a bunch of NULL
    pointer accesses first (not that those have any visible effect on
    Veyron, but that's another problem...)
    
    Change-Id: I3d012fc9af9da6e01159990a6bdd62c38fc22329
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 3a609e17bb9b0ef4d3a833f72fa4fbfd8e8cb0ab
    Original-Change-Id: I0793434116a8c568e19fe0dee24f13942fc50f25
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/238991
    Original-Reviewed-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: http://review.coreboot.org/8758
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See http://review.coreboot.org/8758 for details.

-gerrit



More information about the coreboot-gerrit mailing list