[coreboot-gerrit] Patch merged into coreboot/master: 66fc77d libpayload: mips: add memcmp to the MIPS string functions
gerrit at coreboot.org
gerrit at coreboot.org
Sat Mar 21 11:08:21 CET 2015
the following patch was just integrated into master:
commit 66fc77d3afbefa7b755bf0f025556b23ae4cff2c
Author: Ionela Voinescu <ionela.voinescu at imgtec.com>
Date: Wed Jan 21 01:11:56 2015 +0000
libpayload: mips: add memcmp to the MIPS string functions
The default string functions work with multiple of 4 bytes
(sizeof(unsinged long)); MIPS will use LW/SW instructions
for these operations and if the source and destination
addresses are not aligned it will trigger an exception.
Therefore, this implementation does all data access operations
per byte, because there is no guarantee that the provided
strings are properly aligned.
BUG=chrome-os-partner:31438
TEST=tested on Pistachio bring up board; behaves as expected
BRANCH=none
Change-Id: I05b43673deb954f022d12cb9c3d7baac26be2a34
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: 8e13b3d31726404abd8c8e5c8780d3d3e16e032d
Original-Change-Id: I456e312eb6b7fee2eff10e461af7f578aed07648
Original-Signed-off-by: Ionela Voinescu <ionela.voinescu at imgtec.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/241885
Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
Reviewed-on: http://review.coreboot.org/8743
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
See http://review.coreboot.org/8743 for details.
-gerrit
More information about the coreboot-gerrit
mailing list