[coreboot-gerrit] Patch merged into coreboot/master: 1a3349f cbfstool: Simplify the common buffer_splice() function's interface

gerrit at coreboot.org gerrit at coreboot.org
Fri May 8 20:25:05 CEST 2015


the following patch was just integrated into master:
commit 1a3349ffd1a8b9e0e656ea9ac889ce71860864c0
Author: Sol Boucher <solb at chromium.org>
Date:   Tue May 5 18:25:18 2015 -0700

    cbfstool: Simplify the common buffer_splice() function's interface
    
    Previously, this function allowed one to pass a size of 0 in order to
    indicate that the entire buffer should be copied. However, the
    semantics of calling it this way were non-obvious: The desired
    behavior was clear when the offset was also 0, but what was the
    expected outcome when the offset was nonzero, since carrying over the
    original size in this case would be an error? In fact, it turns out
    that it always ignored the provided offset when the size was zero.
    This commit eliminates all special handling of 0; thus, the resulting
    buffer is exactly as large as requested, even if it's degenerate.
    Since the only consumer that actually called the function with a size
    of 0 was buffer_clone(), no other files required changes.
    
    Change-Id: I1baa5dbaa7ba5bd746e8b1e08816335183bd5d2d
    Signed-off-by: Sol Boucher <solb at chromium.org>
    Reviewed-on: http://review.coreboot.org/10132
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See http://review.coreboot.org/10132 for details.

-gerrit



More information about the coreboot-gerrit mailing list