[coreboot-gerrit] Patch merged into coreboot/master: cbfstool: Allows mixed-state fmap regions to work

gerrit at coreboot.org gerrit at coreboot.org
Fri Nov 13 00:53:17 CET 2015


the following patch was just integrated into master:
commit 7db2b6cacc237dda66d927ada3cecd634c89fdb4
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Wed Nov 11 15:35:24 2015 +0100

    cbfstool: Allows mixed-state fmap regions to work
    
    When using FMAP regions (with option -r) that were generated with a
    master header (as done by cbfstool copy, eg. in Chrome OS' build
    system), there were differences in interpretation of the master header's
    fields.
    
    Normalize for that by not sanity-checking the master header's size field
    (there are enough other tests) and by dealing with region offsets
    properly.
    
    BUG=chromium:445938
    BRANCH=tot
    TEST=`cbfstool /build/veyron_minnie/firmware/image.dev.bin print -r
    FW_MAIN_A` shows that region's directory (instead of claiming that
    there's no CBFS at all, or showing an empty directory).
    
    Change-Id: Ia840c823739d4ca144a7f861573d6d1b4113d799
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 0e5364d291f45e4705e83c0331e128e35ab226d3
    Original-Change-Id: Ie28edbf55ec56b7c78160000290ef3c57fda0f0e
    Original-Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/312210
    Original-Commit-Ready: Patrick Georgi <pgeorgi at chromium.org>
    Original-Tested-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/12416
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/12416 for details.

-gerrit



More information about the coreboot-gerrit mailing list