[coreboot-gerrit] New patch to review for coreboot: Allow adding of bootsplash image to CBFS without checking of VGA_ROM_RUN and VESA options
Aladyshev Konstantin (aladyshev22@gmail.com)
gerrit at coreboot.org
Thu Oct 22 21:09:06 CEST 2015
Aladyshev Konstantin (aladyshev22 at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/12129
-gerrit
commit 690906c515b4595afb33307f7189497b6cd088f4
Author: Konstantin Aladyshev <aladyshev at nicevt.ru>
Date: Sat Jan 24 18:52:10 2015 +0400
Allow adding of bootsplash image to CBFS without checking of VGA_ROM_RUN and VESA options
Possibility of adding a bootsplash image to ROM should be independent
from checking of VGA_ROM_RUN and VESA menuconfig options.
For example, stored image could be saved in CBFS not for coreboot
but for later use in seabios.
Change-Id: I3a0ed53489c40d4d44bd4ebc358ae6667e6c797f
Signed-off-by: Konstantin Aladyshev <aladyshev at nicevt.ru>
---
Makefile.inc | 2 +-
src/Kconfig | 16 ++++++++++++++++
src/device/Kconfig | 13 +------------
3 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/Makefile.inc b/Makefile.inc
index 3a0d0bc..20ac422 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -661,7 +661,7 @@ endif
@printf " CBFSPRINT $(subst $(obj)/,,$(@))\n\n"
$(CBFSTOOL) $@ print
-cbfs-files-$(CONFIG_BOOTSPLASH) += bootsplash.jpg
+cbfs-files-$(CONFIG_BOOTSPLASH_IMAGE) += bootsplash.jpg
bootsplash.jpg-file := $(call strip_quotes,$(CONFIG_BOOTSPLASH_FILE))
bootsplash.jpg-type := bootsplash
diff --git a/src/Kconfig b/src/Kconfig
index 368384d..9048c1f 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -325,6 +325,22 @@ config RAM_CODE_SUPPORT
If enabled, coreboot discovers RAM configuration (value obtained by
reading board straps) and stores it in coreboot table.
+config BOOTSPLASH_IMAGE
+ bool "Add a bootsplash image"
+ help
+ Select this option if you have a bootsplash image that you would
+ like to add to your ROM.
+ This will only add image to ROM. To actually run it check options
+ under 'Display' section
+
+config BOOTSPLASH_FILE
+ string "Bootsplash path and filename"
+ depends on BOOTSPLASH_IMAGE
+ default "bootsplash.jpg"
+ help
+ The path and filename of the file to use as graphical bootsplash
+ screen. The file format has to be jpg.
+
endmenu
source "src/acpi/Kconfig"
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 613461b..133609e 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -547,20 +547,9 @@ config FRAMEBUFFER_KEEP_VESA_MODE
config BOOTSPLASH
prompt "Show graphical bootsplash"
bool
- depends on FRAMEBUFFER_SET_VESA_MODE
+ depends on FRAMEBUFFER_SET_VESA_MODE && BOOTSPLASH_IMAGE
help
This option shows a graphical bootsplash screen. The graphics are
loaded from the CBFS file bootsplash.jpg.
- You will be able to specify the location and file name of the
- image later.
-
-config BOOTSPLASH_FILE
- string "Bootsplash path and filename"
- depends on BOOTSPLASH
- default "bootsplash.jpg"
- help
- The path and filename of the file to use as graphical bootsplash
- screen. The file format has to be jpg.
-
endmenu
More information about the coreboot-gerrit
mailing list