[coreboot-gerrit] New patch to review for coreboot: x86: remove unused sections from romstage.ld

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Fri Sep 4 17:40:49 CET 2015


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11505

-gerrit

commit 4517f7e1dbb24ce08a7da07b365983e9cdd8ab0c
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Sep 3 14:39:39 2015 -0500

    x86: remove unused sections from romstage.ld
    
    Now that the only source of ELF sections for romstage are
    from directly included .inc files or ROMCC generated inc
    files the subsection globs can be removed. i.e. Remove
    .rom.data.* and .rom.text.* listings. Lastly, put the
    .rom.data section directly after the .rom.text. They
    are by definition read-only and they are generated from
    the same place.
    
    BUG=chrome-os-partner:44827
    BRANCH=None
    TEST=Spot checked !ROMCC and ROMCC boards. Confirmed
         only .rom.text .rom.data sections exist.
    
    Change-Id: Id17cf95c943103de006c5f3f21a625838ab49929
    Signed-off-by: Aaron Durbin <adubin at chromium.org>
---
 src/arch/x86/romstage.ld | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/arch/x86/romstage.ld b/src/arch/x86/romstage.ld
index 951ca65..cc0142e 100644
--- a/src/arch/x86/romstage.ld
+++ b/src/arch/x86/romstage.ld
@@ -26,17 +26,15 @@ SECTIONS
 	.rom . : {
 		_rom = .;
 		*(.rom.text);
-		*(.rom.text.*);
+		*(.rom.data);
 		*(.text);
 		*(.text.*);
-		*(.rom.data);
 		. = ALIGN(4);
 		_cbmem_init_hooks = .;
 		KEEP(*(.rodata.cbmem_init_hooks));
 		_ecbmem_init_hooks = .;
 		*(.rodata);
 		*(.rodata.*);
-		*(.rom.data.*);
 		. = ALIGN(16);
 		_erom = .;
 	}



More information about the coreboot-gerrit mailing list