[coreboot-gerrit] Patch set updated for coreboot: rules.h: add fall through where no ENV_<STAGE> is set

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Fri Sep 4 21:36:56 CET 2015


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11513

-gerrit

commit e7e42da91e32560822196826e8ac675453d9ecbf
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Fri Sep 4 16:28:15 2015 -0500

    rules.h: add fall through where no ENV_<STAGE> is set
    
    There are cases where rules.h can be pulled in, but the
    usage is not associated with a particular stage. For
    example, the cpu/ti/am335x build creates an opmap header.
    That is a case where there is no stage associated with
    the process. Therefore, provide a case of no ENV_>STAGE>
    being set.
    
    BUG=chrome-os-partner:44827
    BRANCH=None
    TEST=Built a myriad of boards. Analyzed readelf output.
    
    Change-Id: Ia9688886d445c961f4a448fc7bfcb28f691609db
    Signed-off-by: Aaron Durbin <adubin at chromium.org>
---
 src/include/rules.h | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/include/rules.h b/src/include/rules.h
index 523031a..2e7f88f 100644
--- a/src/include/rules.h
+++ b/src/include/rules.h
@@ -63,13 +63,23 @@
 #define ENV_SECMON 0
 #define ENV_VERSTAGE 1
 
-#else
+#elif defined(__RAMSTAGE__)
 #define ENV_BOOTBLOCK 0
 #define ENV_ROMSTAGE 0
 #define ENV_RAMSTAGE 1
 #define ENV_SMM 0
 #define ENV_SECMON 0
 #define ENV_VERSTAGE 0
+
+#else
+/* Default case of nothing set for random blob generation using
+ * create_class_compiler that isn't bound to a stage. */
+#define ENV_BOOTBLOCK 0
+#define ENV_ROMSTAGE 0
+#define ENV_RAMSTAGE 0
+#define ENV_SMM 0
+#define ENV_SECMON 0
+#define ENV_VERSTAGE 0
 #endif
 
 /* For romstage and ramstage always build with simple device model, ie.



More information about the coreboot-gerrit mailing list