[coreboot-gerrit] New patch to review for coreboot: buildgcc: Show the progress when downloading *still working*.

Zheng Bao (zheng.bao@amd.com) gerrit at coreboot.org
Sun Sep 6 06:11:09 CET 2015


Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11520

-gerrit

commit 1f6246dd823c1d3cb39603a177d1aa5ee2c345c6
Author: zbao <fishbaozi at gmail.com>
Date:   Sun Sep 6 02:10:42 2015 -0400

    buildgcc: Show the progress when downloading *still working*.
    
    For some systems, the commands are buffered by default. On these
    systems, the progress can not been seen, except the final "ok".
    
    Change-Id: I4559e88d541738a594dce92e23589992f234cb9b
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 util/crossgcc/buildgcc | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index 0ed9a39..a8612ca 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -188,6 +188,13 @@ compute_sum() {
 	printf "(checksum created. ${RED}Note. Please upload sum/$1.cksum if the corresponding archive is upgraded.)${NC}"
 }
 
+download_one() {
+	url=$1
+	printf " ..    "
+	wget --no-check-certificate $url 2>&1 | grep --line-buffered -o "[0-9]\+%" | awk '{printf("\b\b\b\b%4s", $1)}'
+	printf "\b\b\b\b${green} ok${NC}"
+}
+
 download() {
 	package=$1
 	archive="$(eval echo \$$package"_ARCHIVE")"
@@ -201,14 +208,13 @@ download() {
 		printf "(downloading from $archive)"
 		rm -f tarballs/$FILE
 		cd tarballs
-		wget --no-check-certificate -q $archive
-		wgetret=$?
+		download_one $archive
 		cd ..
 		compute_sum $FILE
 	fi
 
 	if [ ! -f tarballs/$FILE ]; then
-		printf "\n${RED}Failed to download $FILE. Wget returns $wgetret. See 'man wget'.${NC}\n"
+		printf "\n${RED}Failed to download $FILE.${NC}\n"
 		exit 1
 	fi
 	printf "\n"



More information about the coreboot-gerrit mailing list