[coreboot-gerrit] New patch to review for coreboot: glados: Select EC PD and call early EC init

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Sep 7 18:43:20 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11573

-gerrit

commit 63f24d83bd6e9abc610f9539ae5617a6e574d1f6
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Fri Sep 4 10:17:13 2015 -0700

    glados: Select EC PD and call early EC init
    
    Select the EC PD support in kconfig and call the EC early init
    code that will reboot into RO for recovery mode.
    
    BUG=chrome-os-partner:40635
    BRANCH=none
    TEST=boot on glados in recovery mode
    
    Change-Id: Ifa1e2afd91a247c3830d8e705d9d34fb02239fe4
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 135ef6e0e2c4864be1c25a9761e04cfe17aec51e
    Original-Change-Id: Iac8c092453bfbd94210462be0b377fb77410941d
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/297749
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/google/glados/Kconfig    | 3 ++-
 src/mainboard/google/glados/romstage.c | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index a80e16f..26fd08b 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -6,9 +6,10 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_16384
 	select CACHE_ROM
 	select EC_GOOGLE_CHROMEEC
+	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
 	select EC_GOOGLE_CHROMEEC_LPC
 	select EC_GOOGLE_CHROMEEC_MEC
-	select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP
+	select EC_GOOGLE_CHROMEEC_PD
 	select HAVE_ACPI_RESUME
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
diff --git a/src/mainboard/google/glados/romstage.c b/src/mainboard/google/glados/romstage.c
index 44a896f..315ddb9 100644
--- a/src/mainboard/google/glados/romstage.c
+++ b/src/mainboard/google/glados/romstage.c
@@ -41,6 +41,9 @@ static void early_config_gpio(void)
 
 void mainboard_romstage_entry(struct romstage_params *params)
 {
+	/* Ensure the EC and PD are in the right mode for recovery */
+	google_chromeec_early_init();
+
 	early_config_gpio();
 
 	/* Fill out PEI DATA */



More information about the coreboot-gerrit mailing list