[coreboot-gerrit] Patch set updated for coreboot: ifdtool: Enable warnings as errors, and fix any issues

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Thu Sep 10 16:00:18 CET 2015


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11613

-gerrit

commit 5b2078ab9dfd17086e62db1a311f92781dbdc9ea
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Thu Sep 10 08:37:42 2015 -0700

    ifdtool: Enable warnings as errors, and fix any issues
    
    Change-Id: Id462a10c2affac54ec48a1cc2a5b2ca66112848e
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 util/ifdtool/Makefile  | 2 +-
 util/ifdtool/ifdtool.c | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile
index a234ded..02a02c4 100644
--- a/util/ifdtool/Makefile
+++ b/util/ifdtool/Makefile
@@ -22,7 +22,7 @@ PROGRAM = ifdtool
 CC      = gcc
 INSTALL = /usr/bin/install
 PREFIX  = /usr/local
-CFLAGS  = -O2 -g -Wall -W
+CFLAGS  = -O2 -g -Wall -W -Werror
 LDFLAGS =
 
 OBJS = ifdtool.o
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c
index 214998c..e6ed110 100644
--- a/util/ifdtool/ifdtool.c
+++ b/util/ifdtool/ifdtool.c
@@ -42,7 +42,7 @@ static const struct region_name region_names[MAX_REGIONS] = {
 	{ "Reserved", "res1" },
 	{ "Reserved", "res2" },
 	{ "Reserved", "res3" },
-	{ "EC" "ec" },
+	{ "EC", "ec" },
 };
 
 static fdbar_t *find_fd(char *image, int size)
@@ -729,6 +729,9 @@ static void set_em100_mode(char *filename, char *image, int size)
 	case IFD_VERSION_2:
 		freq = SPI_FREQUENCY_17MHZ;
 		break;
+	default:
+		freq = SPI_FREQUENCY_17MHZ;
+		break;
 	}
 
 	fcba->flcomp &= ~(1 << 30);



More information about the coreboot-gerrit mailing list