[coreboot-gerrit] New patch to review for coreboot: abuild: don't create junit tests with empty testclass field
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Tue Sep 15 17:33:04 CET 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11640
-gerrit
commit 627e2c598712a68c3dc8eb1724b20188f78d7c9a
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Tue Sep 15 16:57:04 2015 +0200
abuild: don't create junit tests with empty testclass field
Variable expansion made abuild create board..foo/bar, which are annoying
on jenkins' web UI because it doesn't cope properly with the empty
namespace between the dots. make it create board.foo/bar or
board.$class.foo/bar.
Change-Id: Ifa79cbfd1f263e11a458b3cc320baeed6a3fbc98
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
util/abuild/abuild | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/util/abuild/abuild b/util/abuild/abuild
index 9516da5..788ed7d 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -479,7 +479,8 @@ chromeos=false
clean_work=false
customizing=""
configoptions=""
-testclass=
+# testclass needs to be undefined if not used for variable expansion to work
+unset testclass
while true ; do
case "$1" in
-J|--junit) shift; mode=junit; rm -f $XMLFILE ;;
More information about the coreboot-gerrit
mailing list