[coreboot-gerrit] New patch to review for coreboot: buildgcc: Reorganize when IASL is built
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Tue Feb 2 18:51:40 CET 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13563
-gerrit
commit f331c09735cf5a49ba05c6da921edf22b1744931
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date: Fri Jan 29 17:39:07 2016 -0800
buildgcc: Reorganize when IASL is built
Instead of passing a variable around and painstakingly making sure that
one target builds with it, and the others without, make IASL a
dependency of the "catch all" targets.
This also drops iasl as dependency from individual architecture targets,
but things are more orthogonal that way.
Note: instead of `make crossgcc-i386`, use `make crossgcc-i386 iasl`
Change-Id: I8cd2e89acdd0f795836571470bad28fbf8797f58
Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
util/crossgcc/Makefile | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/util/crossgcc/Makefile b/util/crossgcc/Makefile
index fbbadac..11cc5fc 100644
--- a/util/crossgcc/Makefile
+++ b/util/crossgcc/Makefile
@@ -7,18 +7,16 @@ BUILD_PLATFORM ?= i386-elf
# Example: BUILDGCC_OPTIONS=-c to remove temporary files before build
all all_with_gdb:
- $(MAKE) build-i386
- $(MAKE) SKIP_IASL=1 \
- build-x64 build-armv7a build-mips build-riscv build-aarch64 \
- build_clang
+ $(MAKE) build-i386 build-x64 build-arm build-mips \
+ build-riscv build-aarch64 build-power8 build-nds32le \
+ build_clang build_iasl
all_without_gdb:
- $(MAKE) SKIP_GDB=1 build-i386
- $(MAKE) SKIP_IASL=1 SKIP_GDB=1 \
- build-x64 build-armv7a build-mips build-riscv build-aarch64 \
- build_clang
+ $(MAKE) SKIP_GDB=1 build-i386 build-x64 build-arm build-mips \
+ build-riscv build-aarch64 build-power8 build-nds32le \
+ build_clang build_iasl
-build_tools: build_gcc build_iasl build_gdb
+build_tools: build_gcc build_gdb
###########################################################
### targets to do buildgcc builds
@@ -33,9 +31,7 @@ ifeq ($(SKIP_GDB),)
endif
build_iasl:
-ifeq ($(SKIP_IASL),)
bash ./buildgcc -P iasl $(if $(CPUS),-j $(CPUS)) $(if $(KEEP_SOURCES),-t) $(BUILDGCC_OPTIONS)
-endif
build_clang:
ifeq ($(SKIP_CLANG),)
More information about the coreboot-gerrit
mailing list