[coreboot-gerrit] New patch to review for coreboot: Workaround for unused variable warning.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Mon Feb 8 00:11:31 CET 2016


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13624

-gerrit

commit 09a6392e855ba51dfb7552459318eb04c8d1cfa2
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Mon Feb 8 00:10:44 2016 +0100

    Workaround for unused variable warning.
    
    Change-Id: I0a0c925509027f98f724d0a4347146f21ac06c02
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/ec/compal/ene932/acpi/ec.asl       | 2 ++
 src/ec/quanta/it8518/acpi/ec.asl       | 3 +++
 src/ec/smsc/mec1308/acpi/ec.asl        | 2 ++
 src/mainboard/lenovo/t400/acpi/gpe.asl | 2 ++
 src/mainboard/lenovo/t60/acpi/gpe.asl  | 2 ++
 src/mainboard/lenovo/x200/acpi/gpe.asl | 2 ++
 src/mainboard/lenovo/x201/acpi/gpe.asl | 2 ++
 src/mainboard/lenovo/x60/acpi/gpe.asl  | 2 ++
 8 files changed, 17 insertions(+)

diff --git a/src/ec/compal/ene932/acpi/ec.asl b/src/ec/compal/ene932/acpi/ec.asl
index 696c1f6..93ddcbe 100644
--- a/src/ec/compal/ene932/acpi/ec.asl
+++ b/src/ec/compal/ene932/acpi/ec.asl
@@ -270,6 +270,8 @@ Device (EC0)
 
 		// Force a read of CPU temperature
 		Store (CTML, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
 	}
 
 
diff --git a/src/ec/quanta/it8518/acpi/ec.asl b/src/ec/quanta/it8518/acpi/ec.asl
index 0045196..22c7352 100644
--- a/src/ec/quanta/it8518/acpi/ec.asl
+++ b/src/ec/quanta/it8518/acpi/ec.asl
@@ -568,6 +568,9 @@ Device (EC0)
 		// Force a read of CPU temperature
 		// TODO Which temperature corresponds to the CPU?
 		Store (TMP0, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
+
 	}
 
 /* Attention Codes
diff --git a/src/ec/smsc/mec1308/acpi/ec.asl b/src/ec/smsc/mec1308/acpi/ec.asl
index bd840f5..a8de9fa 100644
--- a/src/ec/smsc/mec1308/acpi/ec.asl
+++ b/src/ec/smsc/mec1308/acpi/ec.asl
@@ -81,6 +81,8 @@ Device (EC0)
 
 		// Force a read of CPU temperature
 		Store (CPUT, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
 	}
 
 	PowerResource (FNP0, 0, 0)
diff --git a/src/mainboard/lenovo/t400/acpi/gpe.asl b/src/mainboard/lenovo/t400/acpi/gpe.asl
index b6ac30d..5c900ca 100644
--- a/src/mainboard/lenovo/t400/acpi/gpe.asl
+++ b/src/mainboard/lenovo/t400/acpi/gpe.asl
@@ -20,5 +20,7 @@ Scope (\_GPE)
 	{
 		/* Read EC register to clear wake status */
 		Store(\_SB.PCI0.LPCB.EC.WAKE, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
 	}
 }
diff --git a/src/mainboard/lenovo/t60/acpi/gpe.asl b/src/mainboard/lenovo/t60/acpi/gpe.asl
index 88210ac..3cc25b2 100644
--- a/src/mainboard/lenovo/t60/acpi/gpe.asl
+++ b/src/mainboard/lenovo/t60/acpi/gpe.asl
@@ -21,5 +21,7 @@ Scope (\_GPE)
 	{
 		/* Read EC register to clear wake status */
 		Store(\_SB.PCI0.LPCB.EC.WAKE, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
 	}
 }
diff --git a/src/mainboard/lenovo/x200/acpi/gpe.asl b/src/mainboard/lenovo/x200/acpi/gpe.asl
index b6ac30d..5c900ca 100644
--- a/src/mainboard/lenovo/x200/acpi/gpe.asl
+++ b/src/mainboard/lenovo/x200/acpi/gpe.asl
@@ -20,5 +20,7 @@ Scope (\_GPE)
 	{
 		/* Read EC register to clear wake status */
 		Store(\_SB.PCI0.LPCB.EC.WAKE, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
 	}
 }
diff --git a/src/mainboard/lenovo/x201/acpi/gpe.asl b/src/mainboard/lenovo/x201/acpi/gpe.asl
index 88210ac..3cc25b2 100644
--- a/src/mainboard/lenovo/x201/acpi/gpe.asl
+++ b/src/mainboard/lenovo/x201/acpi/gpe.asl
@@ -21,5 +21,7 @@ Scope (\_GPE)
 	{
 		/* Read EC register to clear wake status */
 		Store(\_SB.PCI0.LPCB.EC.WAKE, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
 	}
 }
diff --git a/src/mainboard/lenovo/x60/acpi/gpe.asl b/src/mainboard/lenovo/x60/acpi/gpe.asl
index 88210ac..3cc25b2 100644
--- a/src/mainboard/lenovo/x60/acpi/gpe.asl
+++ b/src/mainboard/lenovo/x60/acpi/gpe.asl
@@ -21,5 +21,7 @@ Scope (\_GPE)
 	{
 		/* Read EC register to clear wake status */
 		Store(\_SB.PCI0.LPCB.EC.WAKE, Local0)
+		/* So that we don't get a warning that Local0 is unused.  */
+		Increment (Local0)
 	}
 }



More information about the coreboot-gerrit mailing list