[coreboot-gerrit] Patch merged into coreboot/master: arch/arm64: Use correct SPSR.DAIF mask for BL31 and payload

gerrit at coreboot.org gerrit at coreboot.org
Wed Feb 10 09:39:44 CET 2016


the following patch was just integrated into master:
commit 3834520ba1da2587e0e4bcdcc447b110314cb2ee
Author: Julius Werner <jwerner at chromium.org>
Date:   Mon Feb 1 19:47:10 2016 -0800

    arch/arm64: Use correct SPSR.DAIF mask for BL31 and payload
    
    The PSTATE mask bits for Debug exceptions, external Aborts, Interrupts
    and Fast interrupts are usually best left unset: under normal
    circumstances none of those exceptions should occur in firmware, and if
    they do it's better to get a crash close to the code that caused it
    (rather than much later when the kernel first unmasks them). For this
    reason arm64_cpu_init unmasks them right after boot. However, the EL2
    payload was still running with all mask bits set, which this patch
    fixes.
    
    BL31, on the other hand, explicitly wants to be entered with all masks
    set (see calling convention in docs/firmware-design.md), which we had
    previously not been doing. It doesn't seem to make a difference at the
    moment, but since it's explicitly specified we should probably comply.
    
    BRANCH=None
    BUG=None
    TEST=Booted Oak, confirmed with raw_read_daif() in payload that mask
    bits are now cleared.
    
    Change-Id: I04406da4c435ae7d44e2592c41f9807934bbc802
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 6ba55bc23fbde962d91c87dc0f982437572a69a8
    Original-Change-Id: Ic5fbdd4e1cd7933c8b0c7c5fe72eac2022c9553c
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/325056
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/13596
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/13596 for details.

-gerrit



More information about the coreboot-gerrit mailing list