[coreboot-gerrit] Patch set updated for coreboot: die() when attempting to use bounce bufferon non-i386.
Vladimir Serbinenko (phcoder@gmail.com)
gerrit at coreboot.org
Fri Feb 19 18:04:53 CET 2016
Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13750
-gerrit
commit 05be366662f40f79f21902281173f3c0e49b6615
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date: Fri Feb 19 16:44:22 2016 +0100
die() when attempting to use bounce bufferon non-i386.
Only i386 has code to support bounce buffer. For others coreboot
would silently discard part of binary which doesn't work and is a hell to debug.
Instead just die.
Change-Id: I37ae24ea5d13aae95f9856a896700a0408747233
Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
src/lib/selfboot.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c
index 6d86159..1123332 100644
--- a/src/lib/selfboot.c
+++ b/src/lib/selfboot.c
@@ -114,6 +114,10 @@ static int relocate_segment(unsigned long buffer, struct segment *seg)
if (!overlaps_coreboot(seg))
return 0;
+#ifndef __i386__
+ die ("bounce buffer not supported");
+#endif
+
start = seg->s_dstaddr;
middle = start + seg->s_filesz;
end = start + seg->s_memsz;
More information about the coreboot-gerrit
mailing list